475560 - Build error with 10.5 SDK and gcc4.2, Growl related

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[[e-mail]]

I am building Camino using GCC 4.2.1 and 10.5 SDK.
After Growl checked in yesterday my build errors out, as for some reason Growl try to build with 10.4u SDK even if I clearly have 10.5 SDK in my .mozconfig.
See attached .mozconfig and build log.

Commenting out SDKROOT in the Growl.xcodeproject/project.pbxproject seems to do the trick though.

Thanks!

Comment 1

[[e-mail]]

Attachment: .mozconfig

Comment 2

[[e-mail]]

Attachment: Build log

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Comment out SDK variables in Growl.xcodeproj

The solution here is to comment out the SDK settings in the Growl project (like bug 383469 comment 12); Kai confirmed that worked for him.

I want to run through a full set of "stock" builds on my end before requesting review, though.

Comment 4

[Stuart Morgan]

I wonder if it might be better to set a GCC_VERSION instead. I don't really want to get into the game of supporting every possible combination for the building of a tiny shim library.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 359217 [details] [diff] [review]
Comment out SDK variables in Growl.xcodeproj

Stuart and I talked this morning, and I "convinced" him that we should support letting the mozconfig drive the build settings in Growl like we do in the other frameworks and Camino itself.

However, we're not going to support arbitrary compiler/SDK combinations; that is, if Growl doesn't build with gcc4.3.7.5 and the 10.6.1 SDK or whatnot, we're not going to be patching Growl to support that combo.

Comment 6

[Stuart Morgan]

Comment on attachment 359217 [details] [diff] [review]
Comment out SDK variables in Growl.xcodeproj

sr=smorgan

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on cvs trunk.

Comment 8

[philippe (part-time)]

builds succeeds now without hacking Growl.xcodeproject/project.pbxproject

--> verified