Build error with 10.5 SDK and gcc4.2, Growl related

VERIFIED FIXED

Status

VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: krmathis, Assigned: alqahira)

Tracking

Trunk
x86
Mac OS X

Details

Attachments

(3 attachments)

(Reporter)

Description

10 years ago
I am building Camino using GCC 4.2.1 and 10.5 SDK.
After Growl checked in yesterday my build errors out, as for some reason Growl try to build with 10.4u SDK even if I clearly have 10.5 SDK in my .mozconfig.
See attached .mozconfig and build log.

Commenting out SDKROOT in the Growl.xcodeproject/project.pbxproject seems to do the trick though.

Thanks!
(Reporter)

Comment 1

10 years ago
Created attachment 359072 [details]
.mozconfig
(Reporter)

Comment 2

10 years ago
Created attachment 359074 [details]
Build log
Created attachment 359217 [details] [diff] [review]
Comment out SDK variables in Growl.xcodeproj

The solution here is to comment out the SDK settings in the Growl project (like bug 383469 comment 12); Kai confirmed that worked for him.

I want to run through a full set of "stock" builds on my end before requesting review, though.
Assignee: nobody → alqahira
Status: NEW → ASSIGNED

Comment 4

10 years ago
I wonder if it might be better to set a GCC_VERSION instead. I don't really want to get into the game of supporting every possible combination for the building of a tiny shim library.
Summary: Build error with 10.5 SDK, Growl related → Build error with 10.5 SDK and gcc4.2, Growl related
Comment on attachment 359217 [details] [diff] [review]
Comment out SDK variables in Growl.xcodeproj

Stuart and I talked this morning, and I "convinced" him that we should support letting the mozconfig drive the build settings in Growl like we do in the other frameworks and Camino itself.

However, we're not going to support arbitrary compiler/SDK combinations; that is, if Growl doesn't build with gcc4.3.7.5 and the 10.6.1 SDK or whatnot, we're not going to be patching Growl to support that combo.
Attachment #359217 - Flags: superreview?(stuart.morgan+bugzilla)

Updated

10 years ago
Attachment #359217 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+

Comment 6

10 years ago
Comment on attachment 359217 [details] [diff] [review]
Comment out SDK variables in Growl.xcodeproj

sr=smorgan
Checked in on cvs trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
builds succeeds now without hacking Growl.xcodeproject/project.pbxproject

--> verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.