475565 - Make our unit tests pass

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Wil Clouser [:clouserw]]

One of AMO's strengths is all of it's unit tests, but a good portion of them are either out of date or don't run due to memory/configuration issues.

We should fix that.

Comment 1

[Jeff Balogh (:jbalogh)]

Attachment: Fixes developers.test.php

* Matching up comment text and test descriptions.
* Removing Flock from setupValidateTargetApplications.  According to the test
  db, we don't support Flock as a valid target.
* validateTargetApplication and validateManifestData return an error string
  instead of dumping it in the Error controller, so we need to capture the
  return value for testing.
* we use XML style closing brackets.

Comment 2

[Jeff Balogh (:jbalogh)]

Attachment: Fixes image.test.php

* Deleting xfailAddonIcon.  The existing testAddonIcon function does the same
  thing.
* Updating the timestamps of the images.
* Checking for the correct mimetype (matches the test data).

With these two patches, all tests in the Developers and Components groups work. :)

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 359083 [details] [diff] [review]
Fixes developers.test.php

kickass, please commit