Closed
Bug 475711
Opened 16 years ago
Closed 16 years ago
"Restore Default Set" doesn't handle dynamic nodes correctly
Categories
(Toolkit :: Toolbars and Toolbar Customization, defect)
Toolkit
Toolbars and Toolbar Customization
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: neil, Assigned: neil)
References
Details
(Keywords: regression, verified1.9.1)
Attachments
(1 file, 1 obsolete file)
|
1.64 KB,
patch
|
Gavin
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
In bug 407725 I forgot that separators, springs and spacers should be removed from the toolbar and not moved back to the palette.
|
Assignee | |
Comment 1•16 years ago
|
||
|
||
Comment 3•16 years ago
|
||
Comment on attachment 359254 [details] [diff] [review]
Proposed patch
I'd add some brackets and use a temporary for localName, but r=me either way.
Attachment #359254 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Attachment #359937 -
Flags: review?(gavin.sharp)
|
|
||
Updated•16 years ago
|
Attachment #359937 -
Flags: review?(gavin.sharp) → review+
|
|
||
Updated•16 years ago
|
Component: Toolbars → Toolbars and Toolbar Customization
Product: Firefox → Toolkit
QA Contact: toolbars → toolbars
Version: unspecified → 1.9.1 Branch
|
|
||
Comment 5•16 years ago
|
||
We should fix this on the branch as well.
|
|
Assignee | |
Comment 6•16 years ago
|
||
Pushed changeset caa042e73aaa to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•16 years ago
|
||
Comment on attachment 359937 [details] [diff] [review]
Addressed review comments
Safe regression fix.
Attachment #359937 -
Flags: approval1.9.1?
|
||
Comment 8•16 years ago
|
||
Comment on attachment 359937 [details] [diff] [review]
Addressed review comments
a191=beltzner
Attachment #359937 -
Flags: approval1.9.1? → approval1.9.1+
|
|
||
Comment 9•16 years ago
|
||
Can we get a test for this as well? I approved it to get past the regression, but it seems testable.
|
||
Comment 10•16 years ago
|
||
Neil, when are you going to land this on 1.9.1?
|
||
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Updated•16 years ago
|
Attachment #359254 -
Attachment is obsolete: true
|
|
||
Updated•16 years ago
|
Whiteboard: [needs 1.9.1 landing]
Target Milestone: --- → mozilla1.9.2a1
Version: 1.9.1 Branch → Trunk
|
|
||
Comment 11•16 years ago
|
||
Keywords: checkin-needed → fixed1.9.1
Whiteboard: [needs 1.9.1 landing]
|
||
Comment 12•16 years ago
|
||
verified FIXED on builds: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090505 Minefield/3.6a1pre ID:20090505030940
and
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090505 Shiretoko/3.5b5pre ID:20090505030932
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•