469563 - Extra Separators and Flexible Spaces are added to Customize toolbar window after clicking Restore Default Set in the window.

Status: RESOLVED DUPLICATE of bug 475711

(Thunderbird :: Mail Window Front End, defect)

Description

[Michael]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081214 Shiretoko/3.1b3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081214 Lightning/1.0pre Shredder/3.0b2pre ID:20081214031205

In the latest nightly build of Thunderird 3.0b2pre with the latest nightly build of Lightning 1.0pre on Windows XP SP3, I've found that clicking the Cancel button in the Customize Toolbar window (View > Toolbars > Customize...) adds 2 Flexible Spaces and 3 Separators to the Customize toolbar window. 

Reproducible: Always

Steps to Reproduce:
1. Open up the Customize Toolbar window (View > Toolbars > Customize...)
2. Click the Cancel button in the Customize Toolbar window.
3. Open up the Customize Toolbar window again (View > Toolbars > Customize...)
Actual Results:  
2 extra Flexible Spaces and 3 extra Separators have been added to Customize Toolbar window.

Expected Results:  
No additional toolbar buttons added to the window.

Exiting Thunderbird  and restarting it seems to erase all of the extra toolbar buttons in the Customize Toobars window. Also, in the Calendaring toolbars, there is a similar bug where only 1 extra Flexible Space and 1 extra Separator is added every time you click cancel on its Customize Toolbar window. If that is a separate issue, please let me know so I can file a separate bug report.

Comment 1

[Michael]

Attachment: Customize Toolbar window

Here's a screenshot of the Customize Toolbar window with the extra toolbar buttons.

Comment 2

[Pardal Freudenthal (:ShareBird)]

I can confirm this with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081221 Shredder/3.0b2pre without Lightning.

Comment 3

[Michael]

Thank you. I don't know if developers will find this useful or not, but I've just noticed in the latest nightly build (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081222 Lightning/1.0pre Shredder/3.0b2pre ID:20081222031211) that only 2 of each of the extra Flexible Spaces and Separators appear now.

Comment 4

[Martin Schröder [:mschroeder]]

Seems to be a Lightning problem.

Comment 5

[Martin Schröder [:mschroeder]]

Sorry, reverting after reading comment#2 once again.

Comment 6

[Stefan Sitter [:ssitter]]

I see a similar issue. Every click on "Restore Default Set" in the Customize Toolbar dialog adds additional Flexible Spaces and Separators to the window.

Fails in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090108 Shredder/3.0b2pre.

Fails in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090108 Calendar/1.0pre.

Works in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090108 Shiretoko/3.1b3pre.

Maybe something changed in Toolkit but only Firefox was updated.

Comment 7

[Magnus Melin [:mkmelin]]

Since the landing of bug 363981 earlier today we don't have a Cancel button anymore.

->WFM

Comment 8

[Stefan Sitter [:ssitter]]

(In reply to comment #7)

It is still possible to reproduce this issue using the "Restore Default Set" button instead of the "Cancel" in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090126 Shredder/3.0b2pre (BuildID: 20090126141743).

Comment 9

[Magnus Melin [:mkmelin]]

I see that too.

Comment 10

[Magnus Melin [:mkmelin]]

Suspect it might be because of the 

Error: menuItems[0] is undefined
Source File: chrome://messenger/content/search.xml
Line: 99

error... probably causing us not to get to the code that removes the old ones.

Comment 11

[Phil Ringnalda (:philor)]

Nah, it's all Neil's fault :)