475981 - test_popup_button.xul : "Warning: XUL box for title element contained an inline #text child, forcing all its children to be wrapped in a block."

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Serge Gautherie (:sgautherie)]

(Noticed while testing bug 475451.)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090127 Minefield/3.2a1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/13e95c7ff78b + bug 446300 patch)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090129 SeaMonkey/2.0a3pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/01c42e286b4c
 +http://hg.mozilla.org/comm-central/rev/dcb38165108d)

{
Warning: XUL box for title element contained an inline #text child, forcing all its children to be wrapped in a block.
Source File: http://localhost:8888/tests/toolkit/content/tests/widgets/test_popup_button.xul?autorun=1&closeWhenDone=1
Line: 0

Warning: XUL box for title element contained an inline #text child, forcing all its children to be wrapped in a block.
Source File: http://localhost:8888/tests/toolkit/content/tests/widgets/window_popup_button.xul
Line: 0
}

Comment 1

[Neil Deakin]

There are a bunch of tests that contain <title> elements in the xul namespace. These should just be removed as they aren't useful. Someone could easily write a patch to remove these.

Comment 2

[Neil Deakin]

Attachment: notitles

Remove all of the title tags, as well as a bunch of unused html namespace declarations.

There's a also a couple of places where I change <binding> to use display: block to prevent warnings.

Comment 3

[Neil Deakin]

Attachment: notitles, v2, fixes test_popup_moveToAnchor.xul

Test only changes

Comment 4

[[e-mail]]

Comment on attachment 8389903 [details] [diff] [review]
notitles, v2, fixes test_popup_moveToAnchor.xul

>+  <bindings xmlns="http://www.mozilla.org/xbl" style="display: block;"
I'd prefer display: none; if it works.

>-  <button id="button1" label="Button 1" style="margin-top: 40px;"/>
>-  <button id="button2" label="Button 2" style="margin-top: 50px;"/>
>+  <button id="button1" label="Button 1" style="margin-top: 50px;"/>
>+  <button id="button2" label="Button 2" style="margin-top: 60px;"/>
Part of another patch?

Comment 5

[Neil Deakin]

(In reply to [e-mail] from comment #4)
> Comment on attachment 8389903 [details] [diff] [review]
> notitles, v2, fixes test_popup_moveToAnchor.xul
> 
> >+  <bindings xmlns="http://www.mozilla.org/xbl" style="display: block;"
> I'd prefer display: none; if it works.

I'll try it.

> >-  <button id="button1" label="Button 1" style="margin-top: 40px;"/>
> >-  <button id="button2" label="Button 2" style="margin-top: 50px;"/>
> >+  <button id="button1" label="Button 1" style="margin-top: 50px;"/>
> >+  <button id="button2" label="Button 2" style="margin-top: 60px;"/>
> Part of another patch?

No, the title element takes up one line of space and affects the position from the top of the frame, so I moved the margin down to accomodate this.

Comment 6

[Neil Deakin]

(In reply to Neil Deakin from comment #5)
> 
> I'll try it.

OK, it works if I wrap it in a hidden box, so I'll do that.

Comment 7

[[e-mail]]

(In reply to comment #4)
> (From update of attachment 8389903 [details] [diff] [review])
> >+  <bindings xmlns="http://www.mozilla.org/xbl" style="display: block;"
> I'd prefer display: none; if it works.
By my testing, neither works, because XBL elements don't support an inline style attribute. Do you have a stylesheet you could use? Otherwise the hidden box sounds like the simplest solution.

Comment 8

[Neil Deakin]

I'm just going to use a hidden box.

Comment 9

[[e-mail]]

Comment on attachment 8389903 [details] [diff] [review]
notitles, v2, fixes test_popup_moveToAnchor.xul

r=me on the non-XBL changes.

Comment 10

[Neil Deakin]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bbdc558a0bb2

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/bbdc558a0bb2