Closed Bug 475981 Opened 11 years ago Closed 6 years ago

test_popup_button.xul : "Warning: XUL box for title element contained an inline #text child, forcing all its children to be wrapped in a block."

Categories

(Toolkit :: XUL Widgets, defect, minor)

x86
Windows 2000
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: sgautherie, Assigned: enndeakin)

Details

Attachments

(1 file, 1 obsolete file)

(Noticed while testing bug 475451.)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090127 Minefield/3.2a1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/13e95c7ff78b + bug 446300 patch)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090129 SeaMonkey/2.0a3pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/01c42e286b4c
 +http://hg.mozilla.org/comm-central/rev/dcb38165108d)

{
Warning: XUL box for title element contained an inline #text child, forcing all its children to be wrapped in a block.
Source File: http://localhost:8888/tests/toolkit/content/tests/widgets/test_popup_button.xul?autorun=1&closeWhenDone=1
Line: 0

Warning: XUL box for title element contained an inline #text child, forcing all its children to be wrapped in a block.
Source File: http://localhost:8888/tests/toolkit/content/tests/widgets/window_popup_button.xul
Line: 0
}
Flags: wanted1.9.2?
There are a bunch of tests that contain <title> elements in the xul namespace. These should just be removed as they aren't useful. Someone could easily write a patch to remove these.
Flags: wanted1.9.2?
Attached patch notitles (obsolete) — Splinter Review
Remove all of the title tags, as well as a bunch of unused html namespace declarations.

There's a also a couple of places where I change <binding> to use display: block to prevent warnings.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Test only changes
Attachment #8376379 - Attachment is obsolete: true
Attachment #8389903 - Flags: review?(neil)
Comment on attachment 8389903 [details] [diff] [review]
notitles, v2, fixes test_popup_moveToAnchor.xul

>+  <bindings xmlns="http://www.mozilla.org/xbl" style="display: block;"
I'd prefer display: none; if it works.

>-  <button id="button1" label="Button 1" style="margin-top: 40px;"/>
>-  <button id="button2" label="Button 2" style="margin-top: 50px;"/>
>+  <button id="button1" label="Button 1" style="margin-top: 50px;"/>
>+  <button id="button2" label="Button 2" style="margin-top: 60px;"/>
Part of another patch?
(In reply to neil@parkwaycc.co.uk from comment #4)
> Comment on attachment 8389903 [details] [diff] [review]
> notitles, v2, fixes test_popup_moveToAnchor.xul
> 
> >+  <bindings xmlns="http://www.mozilla.org/xbl" style="display: block;"
> I'd prefer display: none; if it works.

I'll try it.

> >-  <button id="button1" label="Button 1" style="margin-top: 40px;"/>
> >-  <button id="button2" label="Button 2" style="margin-top: 50px;"/>
> >+  <button id="button1" label="Button 1" style="margin-top: 50px;"/>
> >+  <button id="button2" label="Button 2" style="margin-top: 60px;"/>
> Part of another patch?

No, the title element takes up one line of space and affects the position from the top of the frame, so I moved the margin down to accomodate this.
(In reply to Neil Deakin from comment #5)
> 
> I'll try it.

OK, it works if I wrap it in a hidden box, so I'll do that.
(In reply to comment #4)
> (From update of attachment 8389903 [details] [diff] [review])
> >+  <bindings xmlns="http://www.mozilla.org/xbl" style="display: block;"
> I'd prefer display: none; if it works.
By my testing, neither works, because XBL elements don't support an inline style attribute. Do you have a stylesheet you could use? Otherwise the hidden box sounds like the simplest solution.
I'm just going to use a hidden box.
Comment on attachment 8389903 [details] [diff] [review]
notitles, v2, fixes test_popup_moveToAnchor.xul

r=me on the non-XBL changes.
Attachment #8389903 - Flags: review?(neil) → review+
https://hg.mozilla.org/mozilla-central/rev/bbdc558a0bb2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.