476020 - Pressing Esc while having the tag autocomplete open closes the bookmarks panel

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090127 Shiretoko/3.1b3pre Ubiquity/0.1.5 ID:20090127021057

This bug is similar to bug 462662 but handles the Esc key. Until know we still close the dialog even when the tag auto-completion menu is open.

Steps:
1. Open a page and bookmark it with a tag
2. Open another page and bookmark it too (via Ctrl/Cmd+D)
3. Selecting the tag field and enter the first letter from the tag of step 1
4. Press Esc

With step 4 we only should close the auto-completion menu but not the bookmarks panel.

Comment 1

[Marco Bonardo [:mak]]

mh, ESC is however an acronym to interrupt an operation, something to polish but probably less negative than saving a full dialog on enter through an autoselect.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Speaking in that way it's more a dataloss issue. When someone is hitting accidentally the Esc key while having already entered another name and other tags everything is lost. Added bookmarks can easily be removed.

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch v1.0

this should be enough

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 359659 [details] [diff] [review]
patch v1.0

r=me. please add a comment describing the cases this covers.

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.1

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/01748c44e5db

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 359734 [details] [diff] [review]
patch v1.1

minor polish, low risk

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090131 Minefield/3.2a1pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090201 Minefield/3.2a1pre

Aakash, can you include this into the litmus test, you already have created on bug 462662? But lets wait for the 3.1 branch fix.

Comment 9

[Aakash Desai [:aakashd]]

Ok, the litmus test case, https://litmus.mozilla.org/show_test.cgi?id=7468 , was updated to regression test this bug.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Tracy, we left the question mark because this test cannot be enabled right now. We need the check-in for FF3.1 first. Do you see a better way to handle disabled tests or tests which were created before the original bug will be filed?

Comment 11

[Aakash Desai [:aakashd]]

Re-enabling the litmus test case as this has been verified FIXED

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Aakash, have you read comment 10? There was no change yet. The patch isn't in 1.9.1.

Comment 13

[Marco Bonardo [:mak]]

a test is being added in bug 485458

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With the automated test we don't need a Litmus test anymore. Removing flag.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 359734 [details] [diff] [review]
patch v1.1

a191=beltzner

Comment 16

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/263032bde4fa

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on 1.9.1 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090416 Shiretoko/3.5b4pre ID:20090416030924 and an appropriate build on WinXP.

Comment 18

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv