Closed Bug 485458 Opened 11 years ago Closed 11 years ago

browser-chrome test for bookmarks Properties dialog

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 3.6a1

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: fixed1.9.1)

Attachments

(2 files, 2 obsolete files)

Need a test for this dialog
Please see Bug 481690
"Undo" of the edit context menu is useless in the library and the Properties window.
that is a separate bug, won't take take of it here, purpose of this bug is only to create a test where we can add test cases in future.
Attached patch patch v1.0 (obsolete) — Splinter Review
This was an interesting task... While writing the test i've found a problem in the _initialized property of editItemOverlay, is fixed here, simply an assignment move.
Attachment #369685 - Attachment is obsolete: true
Attachment #369811 - Flags: review?(dietrich)
ops. the head_bookmarks.js change is unwanted, so please ignore that.
Attached patch patch v1.1Splinter Review
minor cleanup, removed non test changes (the editBookmarkOverlay change should land before this with bug 427633 chrome test.
Attachment #369811 - Attachment is obsolete: true
Attachment #370442 - Flags: review?(dietrich)
Attachment #369811 - Flags: review?(dietrich)
Comment on attachment 370442 [details] [diff] [review]
patch v1.1

r=me. please add a list of the common actions for that dialog that are not yet tested (basic add/edit for all types and fields, microsummaries, feeds, etc), and file a followup bug for adding them.
Attachment #370442 - Flags: review?(dietrich) → review+
Blocks: 486510
filed Bug 486510 with a preliminary lists of actions to test.
Flags: in-testsuite?
http://hg.mozilla.org/mozilla-central/rev/ec0413e43e46
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
Flags: in-testsuite? → in-testsuite+
This line in the test is wrong:

  EventUtils.synthesizeKey("VK_ESC", {}, self.window);

It should be VK_ESCAPE not VK_ESC.
Attached patch fix key typoSplinter Review
a small change to fix the wrong key constant
i temporarly disabled the test on 1.9.1 due to some strange crashes, this will be tracked in bug 487040, adding as a dependancy, i don't think the test is directly involved in causing the crash, but helps making that more visible.

on m-c the test is active and testing all the patches, since there crashes happens really rarely.
Depends on: 487040
Seems like the tests work well on trunk and 1.9.1. Thanks Marco!
Status: RESOLVED → VERIFIED
it is disabled on 1.9.1 but working fine on trunk, see comment 14, clearly i want to re enable it on 1.9.1 asap.
Thanks. Resetting flag back to fixed1.9.1. Will recheck when the remaining tests are active.
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.