Mozmill test for check top site - Amazon

VERIFIED FIXED

Status

Mozilla QA
Mozmill Tests
VERIFIED FIXED
9 years ago
6 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill-smokestest][mozmill-layout], URL)

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

9 years ago
Created attachment 359859 [details] [diff] [review]
Patch v1

The following test checks the Amazon website for several elements. That's the only thing we can do in MozMill. With the existing reftests for the top sites,
layout issues will be already covered.
Attachment #359859 - Flags: review?(ctalbert)
(Assignee)

Updated

9 years ago
Depends on: 475719, 476225
(Assignee)

Updated

9 years ago
Blocks: 476231
(Assignee)

Updated

9 years ago
No longer blocks: 476231
Depends on: 476231
No longer depends on: 475719

Updated

9 years ago
No longer depends on: 476231
(Assignee)

Updated

9 years ago
Depends on: 476231

Comment 1

9 years ago
This looks really good, Henrik.  I have a couple of comments though before deciding how to review it:
* Shouldn't the delayed* functions go into a shared module?  They seem like they would be just the right thing for a shared module.

* While I do think this test is good, I'd love to see the test expanded to do the following:
1. Click the first thing that you can buy on the site and add it to the cart
2. Then in the last step, open the cart and ensure that the thing is there.

This would test that the basic functionality of the web application of amazon works, which is enough for us, I believe.  The problem here is whether or not their page is crafted such that there is a general, repeatable way to grab that first element and click "add to cart".  Does that exist?

Once we get these issues sorted, I'll know how to review this test.
(Assignee)

Comment 2

9 years ago
(In reply to comment #1)
> * Shouldn't the delayed* functions go into a shared module?  They seem like
> they would be just the right thing for a shared module.

The question is should this behavior not better integrated into MozMill itself? All tests will run into this problem when handling lazily loaded content. This doesn't only apply for content but also chrome elements - see the bookmarkEditPanel. Mikeal and Adam, what do you both think?

> * While I do think this test is good, I'd love to see the test expanded to do
> the following:
> 1. Click the first thing that you can buy on the site and add it to the cart
> 2. Then in the last step, open the cart and ensure that the thing is there.
> 
> This would test that the basic functionality of the web application of amazon
> works, which is enough for us, I believe.  The problem here is whether or not
> their page is crafted such that there is a general, repeatable way to grab that
> first element and click "add to cart".  Does that exist?

I already had those steps in my test but decided to remove them again because elements varies between different categories. I did some further investigations and it looks like we can use it when we definitely get results from the same category each time. I've modified the second search to "The Police CD" which will return a list of audio cd's. That should work and doesn't fail on my side.

I'll attach an updated version of the patch.
(Assignee)

Comment 3

9 years ago
Created attachment 360288 [details] [diff] [review]
Patch v2 (with cart check)
Attachment #359859 - Attachment is obsolete: true
Attachment #360288 - Flags: review?(ctalbert)
Attachment #359859 - Flags: review?(ctalbert)
(Assignee)

Comment 4

9 years ago
Created attachment 360289 [details] [diff] [review]
Patch v2.1 (checked-in)

Sorry, missed a qrefresh.
Attachment #360288 - Attachment is obsolete: true
Attachment #360289 - Flags: review?(ctalbert)
Attachment #360288 - Flags: review?(ctalbert)

Comment 5

9 years ago
(In reply to comment #2)
> (In reply to comment #1)
> > * Shouldn't the delayed* functions go into a shared module?  They seem like
> > they would be just the right thing for a shared module.
> 
> The question is should this behavior not better integrated into MozMill itself?
> All tests will run into this problem when handling lazily loaded content. This
> doesn't only apply for content but also chrome elements - see the
> bookmarkEditPanel. Mikeal and Adam, what do you both think?
> 
All right, let's open another bug to settle this issue, and leave them in the test as is. 

> > * While I do think this test is good, I'd love to see the test expanded to do
> > the following:
> > 1. Click the first thing that you can buy on the site and add it to the cart
> > 2. Then in the last step, open the cart and ensure that the thing is there.
> > 
> > This would test that the basic functionality of the web application of amazon
> > works, which is enough for us, I believe.  The problem here is whether or not
> > their page is crafted such that there is a general, repeatable way to grab that
> > first element and click "add to cart".  Does that exist?
> 
> I already had those steps in my test but decided to remove them again because
> elements varies between different categories. I did some further investigations
> and it looks like we can use it when we definitely get results from the same
> category each time. I've modified the second search to "The Police CD" which
> will return a list of audio cd's. That should work and doesn't fail on my side.
> 
Sweet, looks good. r=ctalbert
Thanks!

Updated

9 years ago
Attachment #360289 - Flags: review?(ctalbert) → review+
(Assignee)

Comment 6

9 years ago
(In reply to comment #5)
> > The question is should this behavior not better integrated into MozMill itself?
> > All tests will run into this problem when handling lazily loaded content. This
> > doesn't only apply for content but also chrome elements - see the
> > bookmarkEditPanel. Mikeal and Adam, what do you both think?
> > 
> All right, let's open another bug to settle this issue, and leave them in the
> test as is. 

Filed as bug 477135.

Changeset: http://hg.mozilla.org/qa/mozmill-tests/rev/ff329b4c0661
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Depends on: 477135
Resolution: --- → FIXED
(Assignee)

Comment 7

9 years ago
I had to update the test. Let's reopen this bug for now. I think its better to track changes in the same bug. Patch is following...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

9 years ago
Created attachment 372280 [details] [diff] [review]
Follow-up patch

What does the patch update:
* Remove all cookies when test has been finished. The currently checked-in version will fail after the second run.
* Now we can select a category from the select field
* The search field at the bottom has been removed by Amazon

Now it looks much cleaner and the only bug I have to wait is for the delayed action.
Attachment #372280 - Flags: review?(ctalbert)
(Assignee)

Updated

9 years ago
Attachment #372280 - Attachment description: Patch v3.0 → Follow-up patch
(Assignee)

Updated

9 years ago
Attachment #360289 - Attachment description: Patch v2.1 → Patch v2.1 (checked-in)
(Assignee)

Comment 9

9 years ago
Created attachment 372283 [details] [diff] [review]
Follow-up patch v2

Ok, some more cleaning up for this test:

* Removed delayedClick function in favor of delayedAsserNode and our future work in bug 477135
Attachment #372280 - Attachment is obsolete: true
Attachment #372283 - Flags: review?(ctalbert)
Attachment #372280 - Flags: review?(ctalbert)
(Assignee)

Comment 10

9 years ago
Dependencies were introduced and broken elements fixed. We can call it fixed with:
http://hg.mozilla.org/qa/mozmill-tests/rev/9554a9d2373f
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Attachment #372283 - Flags: review?(ctalbert)
(Assignee)

Updated

8 years ago
Depends on: 516729
(Assignee)

Comment 11

8 years ago
No failures anymore with bug 516729 fixed.
Status: RESOLVED → VERIFIED
(Assignee)

Comment 12

7 years ago
Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: General → Mozmill Tests
Product: Firefox → Mozilla QA
QA Contact: general → mozmill-tests
Version: 3.5 Branch → unspecified
Summary: [mozmill] test for check top site - Amazon → Mozmill test for check top site - Amazon
Whiteboard: [mozmill-smokestest][mozmill-layout]
You need to log in before you can comment on or make changes to this bug.