Created attachment 400785 [details] [diff] [review] Full patch As the summary says we fail currently if the element is outside of the content view area. We have to scroll the window to the element before clicking the element. This will fix a couple of failing tests. It would be great when we can get this in ASAP. Clint, the patch doesn't have removed the whitespace changes. It would be great when we could get those in too. Each time I have to worry about it. I hope it is ok. Could you please review and push it to Mikeal if it is ok?
Attachment #400785 - Flags: review?(ctalbert)
Created attachment 400804 [details] [diff] [review] Patch v1 wo/ whitespace changes
Attachment #400804 - Flags: review?(ctalbert)
I'll add a couple of tests which need this fix.
An open question which comes into my mind some minutes ago... we probably need the same for keypress. I will check it later today.
It's not needed for keypress/type. Using those two functions will cause an automatic scroll to the element. Clint, so the existing patches are still valid.
Comment on attachment 400804 [details] [diff] [review] Patch v1 wo/ whitespace changes this looks good. r=ctalbert
Attachment #400804 - Flags: review?(ctalbert) → review+
Thanks. Can you manage to get it into the master? I cannot atm.
I forgot the double click and right click functions. I have to check those too.
Created attachment 401838 [details] [diff] [review] Patch v2 As said above I forgot about the doubleClick and rightClick functions. With this patch both of them are updated too. It also fixes the uninitialized context menu (all options shown when element is not visible).
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
All depending tests pass on low resolution screens.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.