Content elements need to be scrolled into view before clicking on them

VERIFIED FIXED

Status

Testing Graveyard
Mozmill
--
blocker
VERIFIED FIXED
9 years ago
a year ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Dependency tree / graph

Details

(Whiteboard: [mozmill-1.2.2])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

9 years ago
Created attachment 400785 [details] [diff] [review]
Full patch

As the summary says we fail currently if the element is outside of the content view area. We have to scroll the window to the element before clicking the element.

This will fix a couple of failing tests. It would be great when we can get this in ASAP.

Clint, the patch doesn't have removed the whitespace changes. It would be great when we could get those in too. Each time I have to worry about it. I hope it is ok. Could you please review and push it to Mikeal if it is ok?
Attachment #400785 - Flags: review?(ctalbert)
(Assignee)

Updated

9 years ago
Severity: normal → blocker
(Assignee)

Comment 1

9 years ago
Created attachment 400804 [details] [diff] [review]
Patch v1 wo/ whitespace changes
Attachment #400804 - Flags: review?(ctalbert)
(Assignee)

Updated

9 years ago
Blocks: 512283
(Assignee)

Updated

9 years ago
Blocks: 512363
(Assignee)

Comment 2

9 years ago
I'll add a couple of tests which need this fix.
(Assignee)

Comment 3

9 years ago
An open question which comes into my mind some minutes ago... we probably need the same for keypress. I will check it later today.
(Assignee)

Comment 4

9 years ago
It's not needed for keypress/type. Using those two functions will cause an automatic scroll to the element. Clint, so the existing patches are still valid.

Comment 5

9 years ago
Comment on attachment 400804 [details] [diff] [review]
Patch v1 wo/ whitespace changes

this looks good. r=ctalbert
Attachment #400804 - Flags: review?(ctalbert) → review+

Updated

9 years ago
Attachment #400785 - Flags: review?(ctalbert) → review+
(Assignee)

Comment 6

9 years ago
Thanks. Can you manage to get it into the master? I cannot atm.
Keywords: checkin-needed
(Assignee)

Comment 7

9 years ago
I forgot the double click and right click functions. I have to check those too.
Keywords: checkin-needed
(Assignee)

Comment 8

9 years ago
Created attachment 401838 [details] [diff] [review]
Patch v2

As said above I forgot about the doubleClick and rightClick functions. With this patch both of them are updated too. It also fixes the uninitialized context menu (all options shown when element is not visible).
Attachment #400785 - Attachment is obsolete: true
Attachment #400804 - Attachment is obsolete: true
Attachment #401838 - Flags: review?(ctalbert)

Updated

9 years ago
Attachment #401838 - Flags: review?(ctalbert) → review+
(Assignee)

Comment 9

8 years ago
Fixed with: http://github.com/mikeal/mozmill/commit/a15a0ba168dc9f9b6ae27f3abefd883057628b5d
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 10

8 years ago
All depending tests pass on low resolution screens.
Status: RESOLVED → VERIFIED
Whiteboard: [mozmill-1.2.2]
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.