Closed
Bug 516729
Opened 16 years ago
Closed 16 years ago
Content elements need to be scrolled into view before clicking on them
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [mozmill-1.2.2])
Attachments
(1 file, 2 obsolete files)
|
4.75 KB,
patch
|
cmtalbert
:
review+
|
Details | Diff | Splinter Review |
As the summary says we fail currently if the element is outside of the content view area. We have to scroll the window to the element before clicking the element.
This will fix a couple of failing tests. It would be great when we can get this in ASAP.
Clint, the patch doesn't have removed the whitespace changes. It would be great when we could get those in too. Each time I have to worry about it. I hope it is ok. Could you please review and push it to Mikeal if it is ok?
Attachment #400785 -
Flags: review?(ctalbert)
|
Assignee | |
Updated•16 years ago
|
Severity: normal → blocker
|
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #400804 -
Flags: review?(ctalbert)
|
|
Assignee | |
Comment 2•16 years ago
|
||
I'll add a couple of tests which need this fix.
|
|
Assignee | |
Comment 3•16 years ago
|
||
An open question which comes into my mind some minutes ago... we probably need the same for keypress. I will check it later today.
|
|
Assignee | |
Comment 4•16 years ago
|
||
It's not needed for keypress/type. Using those two functions will cause an automatic scroll to the element. Clint, so the existing patches are still valid.
Comment on attachment 400804 [details] [diff] [review]
Patch v1 wo/ whitespace changes
this looks good. r=ctalbert
Attachment #400804 -
Flags: review?(ctalbert) → review+
Attachment #400785 -
Flags: review?(ctalbert) → review+
|
|
Assignee | |
Comment 6•16 years ago
|
||
Thanks. Can you manage to get it into the master? I cannot atm.
Keywords: checkin-needed
|
|
Assignee | |
Comment 7•16 years ago
|
||
I forgot the double click and right click functions. I have to check those too.
Keywords: checkin-needed
|
|
Assignee | |
Comment 8•16 years ago
|
||
As said above I forgot about the doubleClick and rightClick functions. With this patch both of them are updated too. It also fixes the uninitialized context menu (all options shown when element is not visible).
Attachment #400785 -
Attachment is obsolete: true
Attachment #400804 -
Attachment is obsolete: true
Attachment #401838 -
Flags: review?(ctalbert)
Attachment #401838 -
Flags: review?(ctalbert) → review+
|
|
Assignee | |
Comment 9•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 10•16 years ago
|
||
All depending tests pass on low resolution screens.
Status: RESOLVED → VERIFIED
Whiteboard: [mozmill-1.2.2]
|
||
Updated•9 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•