Closed Bug 476327 Opened 14 years ago Closed 14 years ago

Updater window title should be Firefox Update

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3.5b4

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

(Keywords: late-l10n, user-doc-complete, verified1.9.1)

Attachments

(2 files, 1 obsolete file)

screenshot
18.66 KB, image/png
Details
patch rev2
1.43 KB, patch
robert.strong.bugs
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review 
patch coming up
Attached image screenshot — 
Hey beltzner, we talked about doing this when you were here last week. For nightly builds on trunk it would be Minefield, etc.

btw: I filed this under Firefox -> General since there isn't any app update code that needs to change to accomplish this.
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #359972 - Flags: ui-review?(beltzner)
Attached patch patch rev1 (obsolete) — — Splinter Review 
I'll request review after the ui review.
Attached patch patch rev2 — — Splinter Review 

        Attachment #359973 -
        Attachment is obsolete: true

    
    

    
  
If we take this for Firefox 3.1 we should also take the patch in bug 324758 for the sake of consistency since it is also extremely simple.
Depends on: 324758

        Attachment #359973 -
        Flags: review?(mconnor)

    
    

    
  
Comment on attachment 359975 [details] [diff] [review]
patch rev2

verbal r+ from mconnor

        Attachment #359975 -
        Flags: review+

        Attachment #359973 -
        Flags: review?(mconnor)

        Attachment #359972 -
        Flags: ui-review?(beltzner)

    
    

    
  
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/4f2d09f39ec9
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b3

    
    

    
  
Comment on attachment 359975 [details] [diff] [review]
patch rev2

beta 4 fodder

        Attachment #359975 -
        Flags: approval1.9.1?

    
    

    
  
Comment on attachment 359975 [details] [diff] [review]
patch rev2

a191=beltzner

        Attachment #359975 -
        Flags: approval1.9.1? → approval1.9.1+

    
    

    
  
Pushed to mozilla1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/55f67feda326
Keywords: fixed1.9.1
Target Milestone: Firefox 3.1b3 → Firefox 3.5b4

    
    

    
  
Saw "Minefield Update" and "Shiretoko Update" for builds from 4/25

to

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090513 Minefield/3.6a1pre ID:20090513030859

and

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b5pre) Gecko/20090513 Shiretoko/3.5b5pre ID:20090513030639
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1

          You need to log in
          before you can comment on or make changes to this bug.