476336 - Remove check for InfoText from readstrings.cpp

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

This can be done after the dependent bugs are fixed.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Need to do a once over on this before requesting review

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

Ted, now that the dependent bugs are fixed this can be cleaned up a tad. The patch is bigger than it looks because I kept the test ini files numerically ordered.

Comment 3

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/25bc93d09196

Comment 4

[Robert Strong (they/them - no direct email)]

oops... the url is actually
http://hg.mozilla.org/mozilla-central/rev/1a1c36926891

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 364033 [details] [diff] [review]
patch rev2

Drivers, this removes the ability to use InfoText in the updater.ini and updates the tests which is the vast majority of this patch. I'd like it on 1.9.1 so app update consumers don't have the possibility of using it and it is extremely safe.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 364033 [details] [diff] [review]
patch rev2

a191=beltzner

Comment 7

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/acd870c7050e