Closed Bug 476364 Opened 14 years ago Closed 14 years ago

disabled button and menulist color is hardcoded, should use native color

Categories

(Toolkit :: Themes, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
+ drive-by rtl fixes
Attachment #359999 - Flags: review?(neil)
Comment on attachment 359999 [details] [diff] [review]
patch

Sorry, but I can't review pinstripe without some help from the Mozilla Community Giving program.
Attachment #359999 - Flags: review?(neil)
Attachment #359999 - Flags: review?(enndeakin)
Attachment #359999 - Flags: review?(enndeakin) → review+
Comment on attachment 359999 [details] [diff] [review]
patch

>+listbox menulist:not([disabled]) {
>+  color: -moz-DialogText;
>+}
>+

We should probably have a bug on finding out why this is needed and removing this.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/4c297a9717d2
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
(In reply to comment #2)
> (From update of attachment 359999 [details] [diff] [review])
> >+listbox menulist:not([disabled]) {
> >+  color: -moz-DialogText;
> >+}
> >+
> 
> We should probably have a bug on finding out why this is needed and removing
> this.

Filed bug 481655.
Blocks: 277717
You need to log in before you can comment on or make changes to this bug.