476448 - -KPIC is obsolete in Sun Studio 12 SPARC

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ginn Chen]

See http://docs.sun.com/source/820-4180/man1/CC.1.html

We should use -xcode=pic32 instead.

Comment 1

[Ginn Chen]

I'm working on it.
Also I'd like to change to the compiler version check to Sun Studio 12, as some code is known as not working with Sun Studio 11.

I'm testing my patch now.
I'll post it tomorrow.

Comment 2

[Ginn Chen]

Attachment: patch

1) Use -xcode=pic32 instead of -KPIC for Sun Compiler on Solaris/SPARC.
2) Remove the workaround for -xbuiltin option, the patch of Sun Compiler went public on June 2008.
I didn't find an easy way to test whether the compiler is patched.
But I believe most Sun Studio users have updated their compilers, so it's not really needed.
3) Update the compiler requirement to Sun Studio 12 because nanojit uses some new features of Sun Studio 12.

Comment 3

[Jim Blandy :jimb]

Comment on attachment 360255 [details] [diff] [review]
patch

This looks good.

Would it be possible to set SUNSTUDIO_CC and SUNSTUDIO_CXX variables, somewhere around line 400-430, where we set GNU_CC, GNU_CXX, INTEL_CC, and INTEL_CXX, and then test that instead of all these

  if test "$CPU_ARCH" = "sparc" && test "$OS_ARCH" = "SunOS"; then

all over?  Then, the first hunk, substituting -xcode=pic32 for -KPIC, could become its own independent 'elif' clause, a sibling to the 'if test "$GNU_CC"' clause, concerned only with getting the flags right for Sun Studio.  You'd need to duplicate a little code, but I think it would be much easier to determine when a given flag was appropriate, because you'd only be concerned with one compiler at a time.

The 'if test -z "$GNU_CC"' clause in the second hunk could become 'if test "$SUNSTUDIO_CC"'.

Comment 4

[Ginn Chen]

Attachment: patch v2

Comment 5

[Jim Blandy :jimb]

Do people use GNU ld with Sun Studio?

Comment 6

[Jim Blandy :jimb]

Comment on attachment 360484 [details] [diff] [review]
patch v2

This looks great.

My only thought was that it seems more robust to decide whether we're using Sun Studio by the same kinds of tests we use to recognize Intel CC:

   if test "`$CC -help 2>&1 | grep -c 'Intel(R) C Compiler'`" != "0"; then
     INTEL_CC=1
   fi

Comment 7

[Ginn Chen]

(In reply to comment #5)
> Do people use GNU ld with Sun Studio?

I think most people use /usr/ccs/bin/ld with either Sun Studio or gcc on Solaris.
But we can leave it here, in case someone want to use GNU ld.

Comment 8

[Ginn Chen]

Attachment: patch v3 [Checkin: Comment 9]

grep 'Sun C ' / 'Sun C++ '

Comment 9

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/0ebeefbbdac0

Comment 10

[Ginn Chen]

Attachment: fix for Sun Studio Express [Checkin: Comment 11]

The version line of Sun Studio Express compiler (PreRelease of next version of Sun Studio) has its codename between "Sun" and "C "/"C++ ".

So use regexp to test it.

Comment 11

[Ginn Chen]

Fix for Sun Studio Express:
http://hg.mozilla.org/mozilla-central/rev/09c2d14ec324

Comment 12

[Serge Gautherie (:sgautherie)]

What about 1.9.1?

Comment 13

[Ginn Chen]

Attachment: patch for 1.9.1 branch (combined fix for Bug 475393 and Bug 488260) [Checkin: Comment 15]

It's not must to have but better to have.
The fix should only affects Solaris platform with Sun Studio compiler.

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 375012 [details] [diff] [review]
patch for 1.9.1 branch (combined fix for Bug 475393 and Bug 488260)
[Checkin: Comment 15]

a191=beltzner

Comment 15

[Serge Gautherie (:sgautherie)]

Comment on attachment 375012 [details] [diff] [review]
patch for 1.9.1 branch (combined fix for Bug 475393 and Bug 488260)
[Checkin: Comment 15]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7dc4d4af1ee0