Closed Bug 476555 Opened 11 years ago Closed 11 years ago

change "mark as junk" button to "junk"

Categories

(Thunderbird :: Mail Window Front End, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: clarkbw, Assigned: philor)

Details

This is a bug against the current message reader.  Right now we're using the text "mark as junk" for the junk button and it's a bit too verbose.  It makes for a large button which should be fairly small.  I'd like to rename this to a simple "junk" button just like it is on the toolbar (a lowercase version).

Here's what I'd expect the patch to look like, though I imagine we might have to change the label name for l10n to catch the change.  

If we can hurry we could get this in for b2, so marking that as the target.

--- a/mail/locales/en-US/chrome/messenger/msgHdrViewOverlay.dtd
+++ b/mail/locales/en-US/chrome/messenger/msgHdrViewOverlay.dtd
@@ -55,17 +55,17 @@
 <!ENTITY inReplyToField2.label "in-reply-to ">
 <!ENTITY originalWebsite2.label "website ">
 
 <!ENTITY editMessageDescription.label "This is a draft message">
 <!ENTITY editMessageButton.label "Edit…">
 <!ENTITY archiveButton.label "archive">
 <!ENTITY replyButton.label "reply">
 <!ENTITY forwardButton.label "forward">
-<!ENTITY junkButton.label "mark as junk">
+<!ENTITY junkButton.label "junk">
 <!ENTITY trashButton.tooltiptext "delete">
 
 <!ENTITY otherActionsButton.label "other actions">
 <!ENTITY saveAsMenuItem.label "save as…">
 <!ENTITY saveAsMenuItem.accesskey "S">
 <!ENTITY viewSourceMenuItem.label "view source…">
 <!ENTITY viewSourceMenuItem.accesskey "V">
We should probably change the entity name, unfortunately, if i understand l10n rules.
The rule is actually pretty simple: pretend (though it's basically not pretending) that you only have two ways to change a string: one is to call a physical meeting of all the localizers, make sure they are all paying attention to you rather than reading email or doing something else, and then announce the string change, or, slip the change in in the middle of a huge unrelated code-only checkin that lands two minutes before the final handoff of the RC.

No other choices exist, either you want to change "mark as junk" to "junk" in en-US while denying localizers the chance to decide whether they want to change their translation in a similar way, or you want to change it in a way that forces them to decide whether to change or to stick with what they have.

Taking, but I'll do this in the bug about changing the keys for reply and forward to reflect the previous change that removed their ellipses (once I find it again), so we can change all the names to something with a single new pattern.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
http://hg.mozilla.org/comm-central/rev/adae126ae987
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.