Closed Bug 476639 Opened 16 years ago Closed 16 years ago

enable VFP support in tamarin nanojit

Categories

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)

Product:
Tamarin Graveyard
Component:
Baseline JIT (CodegenLIR)
Platform:
ARM
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: edwsmith, Assigned: rreitmai)

References

Details

Attachments

(1 file, 2 obsolete files)

ver 3 - update again
49.27 KB, patch
edwsmith
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch JIT support for VFP instructions (obsolete) — — Splinter Review
Assignee: nobody → edwsmith
Flags: flashplayer-triage+
Flags: flashplayer-qrb+
Blocks: 478870
Attached patch same patch, merged to redux tip (obsolete) — — Splinter Review
patch was generated from this user repo http://hg.mozilla.org/users/edwsmith_adobe.com/arm $ hg update -C vfp $ hg diff -rdefault >vfp.patch not tested.
Attachment #360300 - Attachment is obsolete: true
Assignee: edwsmith → rreitmai
reassign for test and land.
Status: NEW → ASSIGNED
Latest patch crashes vm; will investigate.
Blocks: 481413
No longer blocks: 478870
ver3 of patch currently in testing
Attachment #365584 - Attachment is obsolete: true
Comment on attachment 367831 [details] [diff] [review] ver 3 - update again VFP portion of this code is UNTESTED and will be disabled. In the process of building a test environment, but in the meantime recommend landing this latest patch.
Attachment #367831 - Flags: review?(edwsmith)
Attachment #367831 - Flags: review?(edwsmith) → review+
9523b643f827: ARM Vector floating point (VFP) support - UNTESTED and disabled - rev 1617
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Is this tested on ARMV7 platform? Does Tamarin Central contain this fix? I can test the VFP feature on ARMV7 platform. Could you guys provide some test case?
Tamarin central contains this code, but a subsequent patch (see bug 496988) may be needed for some content. The acceptance test suite contained within the test subdirectory of tamarin can be used to ensure no injections. Subsequent testing has been performed on an ARM11 device.
When I first supplied the patch, I tested it on a v7 board, and the tamarin-redux acceptance suite was passing. I don't know how much v7 testing has been done since then.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: