Closed
Bug 476796
Opened 17 years ago
Closed 17 years ago
Refactor test_nsIAccessibleImage
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: MarcoZ, Assigned: MarcoZ)
References
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
|
8.47 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
1. Refactor the file itself to use common files and functions.
2. Extract name calculation and put the result in namerules.xml.
|
Assignee | |
Comment 1•17 years ago
|
||
Question: How can we test the alt= scenario where this is used to denote a decorative image?
Assignee: nobody → marco.zehe
Status: NEW → ASSIGNED
Attachment #360445 -
Flags: review?(surkov.alexander)
|
||
Comment 2•17 years ago
|
||
(In reply to comment #1)
> Created an attachment (id=360445) [details]
> Possibly incomplete patch
>
> Question: How can we test the alt= scenario where this is used to denote a
> decorative image?
Marco, it sounds this point is missed in logic name markup tests. The meantime could you file bug for this and not move name stuffs from this mochitests?
|
|
Assignee | |
Comment 3•17 years ago
|
||
This patch refactors, but leaves all tests in place for testing the different names. This will be addressed in a different bug.
Attachment #360445 -
Attachment is obsolete: true
Attachment #360664 -
Flags: review?(surkov.alexander)
Attachment #360445 -
Flags: review?(surkov.alexander)
|
|
||
Comment 4•17 years ago
|
||
Comment on attachment 360664 [details] [diff] [review]
Patch2, without moving name tests.
r=me
Attachment #360664 -
Flags: review?(surkov.alexander) → review+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Pushed in changeset:
http://hg.mozilla.org/mozilla-central/rev/94abcf77a175
Filed bug 477015 for the name calculation part.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•