Closed Bug 477015 Opened 11 years ago Closed 8 years ago

Create namerules based tests for accessible name of images.

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: MarcoZ, Assigned: MarcoZ)

References

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

Spun off bug 476796. The namerules architecture currently does not allow alt=  to be defined, which is used to specifically denote a decorative image, and whose accessible name must also be testable.
Attached patch Patch (obsolete) — Splinter Review
Turns out that I could test this with two sets of rules and markup.
Assignee: nobody → marco.zehe
Status: NEW → ASSIGNED
Attachment #360687 - Flags: review?(surkov.alexander)
The patch no longer applied cleanly to trunk. Updated.
Attachment #360687 - Attachment is obsolete: true
Attachment #363103 - Flags: review?(surkov.alexander)
Attachment #360687 - Flags: review?(surkov.alexander)
Marco, thank you for keeping it up to dated.

I would prefer actually to introduce markup support for this special cases. Your way works but it might be not easy understandable. I'll think how to extend our tests to test null names.
ping? (going through surkov's reviews and found this)
Comment on attachment 363103 [details] [diff] [review]
Patch updated to trunk

I've never got around to think how to improve this. I think we can take the patch as it is.
Attachment #363103 - Flags: review?(surkov.alexander) → review+
Inbound land: http://hg.mozilla.org/integration/mozilla-inbound/rev/e170001f3e9b
Flags: in-testsuite+
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/e170001f3e9b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.