476897 - need ability to be disable F7 caret browsing shortcut

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Comment 1

[(dormant account)]

Attachment: new pref

Adds accessibility.disable_browsewithcaret pref

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I think the pref would be best named "accessibility.browserwithcaret_shortcut.enabled", with a default value of true in all.js, no try/catches, and no temporary "disabled" attribute.

Comment 3

[(dormant account)]

Attachment: rev2

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 360575 [details] [diff] [review]
rev2

You don't like semi-colons, eh? :) Please add one on both lines.

I'd also skip the temporary and just put the getBoolPref call in the if(), but r=me either way (but do add a semi-colon after |return|).

Comment 5

[(dormant account)]

Attachment: added ;

Can you stick an r+ on the updated patch

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 360757 [details] [diff] [review]
added ;

>diff --git a/toolkit/content/widgets/browser.xml b/toolkit/content/widgets/browser.xml

>+          var isEnabled = this.mPrefs.getBoolPref("accessibility.browserwithcaret_shortcut.enabled")

Still missing a ; here :)

Comment 7

[(dormant account)]

Attachment: added the other ;

lets try this again. I'm sorry that my genetic predisposition against ; is affecting me this much.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Phil points out that the pref name should contain "browsewithcaret", and not "browserwithcaret". Need to fix that before pushing!

Comment 9

[(dormant account)]

Attachment: changed name to accessibility.browsewithcaret_shortcut.enabled

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Landed as 2accea7cd21d

Comment 11

[Arjan]

Shouldn't the pref-name also be renamed?

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #11)
> Shouldn't the pref-name also be renamed?

Yes

+pref("accessibility.browserwithcaret_shortcut.enabled", true);

should be:

+pref("accessibility.browsewithcaret_shortcut.enabled", true);

Comment 13

[(dormant account)]

Attachment: fixup

Sorry about that

Comment 14

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/3917a3ac2b78