Closed
Bug 477046
Opened 16 years ago
Closed 10 years ago
IMAP Mark as deleted needs better icon or strikethrough on Mac OS X
Categories
(Thunderbird :: Theme, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 45.0
People
(Reporter: nixon049, Assigned: Paenglab)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.00 KB,
patch
|
squib
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090205 Shredder/3.0b2pre ID:20090205025539
Noticed that on Windows marking IMAP mail as deleted applies a red X and strikethrough on message header in the message list to indicate mail has been trashed. On OS X, IMAP mail marked as deleted only gets a light gray circle/slash icon applied, no strikethrough.
This is hard to see. I spent several minutes checking message filters because I thought filters were not running before I finally noticed the light gray icons. Mark as deleted icon should be red (as it is in the Toolbar) not gray to make it more easily visible. Message header should also have strikethrough applied as it is on Windows.
Reproducible: Always
Component: Mail Window Front End → Folder and Message Lists
QA Contact: front-end → folders-message-lists
Comment 1•16 years ago
|
||
Don't know if mac wants it, but to do it - fix the pinstripe theme to do something like
111 treechildren::-moz-tree-cell-text(imapdeleted) {
112 text-decoration: line-through;
113 }
http://mxr.mozilla.org/comm-central/source/mail/themes/gnomestripe/mail/mailWindow1.css#112
Status: UNCONFIRMED → NEW
Ever confirmed: true
Hardware: x86 → All
Comment 2•10 years ago
|
||
bug 543287 is WFM on windows as of 2011. is it also true for Mac, i.e. fixed?
Flags: needinfo?(bmurali5128)
Updated•10 years ago
|
Component: Folder and Message Lists → Theme
Assignee | ||
Comment 3•10 years ago
|
||
Indeed, this is missing on OS X.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8697388 -
Flags: review?(squibblyflabbetydoo)
Comment 4•10 years ago
|
||
Comment on attachment 8697388 [details] [diff] [review]
OsxIMAPdeleted.patch
Review of attachment 8697388 [details] [diff] [review]:
-----------------------------------------------------------------
rs=me. I didn't try this out, since I don't have a Mac, but it looks good.
Attachment #8697388 -
Flags: review?(squibblyflabbetydoo) → review+
Assignee | ||
Comment 5•10 years ago
|
||
I also couldn't test it but it shouldn't break something with this simple style.
Flags: needinfo?(bmurali5128)
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/8c8780e9afb6aa3840745ff46510631340e560ef
Bug 477046 - Use -ine-through on OSX for IMAP deleted messages. r=squib
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 45.0
You need to log in
before you can comment on or make changes to this bug.
Description
•