477113 - Investigate RTL text-align changes throughout the theme because of bug 299837

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[(no longer active)]

Bug 299837 implements "text-align: end", and also fixes the meaning of "left" and "right" for the text-align CSS rule in RTL mode.  This may have some subtle effects on the themes for different platforms, so I'll do this investigation in this bug and attach a patch as needed.

Comment 1

[Boris Zbarsky [:bzbarsky]]

To be precise, the meaning of "text-align: right" is only affected for:

  <xul:treecol>
  <xul:label>

and the meaning of "text-align: left" is only affected for <xul:label>.

Comment 2

[(no longer active)]

Here are the relevant rules, patch forthcoming.

<http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/menulist.css#162>
<http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/menulist.css#144>
<http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/gnomestripe/global/menulist.css#142>
<http://mxr.mozilla.org/mozilla-central/source/browser/themes/pinstripe/browser/places/organizer.css#631>
<http://mxr.mozilla.org/mozilla-central/source/browser/themes/pinstripe/browser/browser.css#1386>

Comment 3

[Dão Gottwald [:dao]]

(In reply to comment #2)
> patch forthcoming.

hm? :)

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 432520 [details] [diff] [review]
patch

>--- a/toolkit/themes/pinstripe/global/datetimepicker.css
>+++ b/toolkit/themes/pinstripe/global/datetimepicker.css
>@@ -60,21 +60,17 @@ datepicker, timepicker {
>   color: -moz-FieldText;
> }
> 
> .datetimepicker-input-subbox {
>   width: 1.6em;
> }
> 
> html|*.datetimepicker-input {
>-  text-align: right;
>-}
>-
>-html|*.datetimepicker-input:-moz-locale-dir(rtl) {
>-  text-align: left;
>+  text-align: end;
> }

I wonder whether this should always be right...

Comment 6

[(no longer active)]

Comment on attachment 432520 [details] [diff] [review]
patch

Thanks for picking up my slack!

(In reply to comment #5)
> (From update of attachment 432520 [details] [diff] [review])
> >--- a/toolkit/themes/pinstripe/global/datetimepicker.css
> >+++ b/toolkit/themes/pinstripe/global/datetimepicker.css
> >@@ -60,21 +60,17 @@ datepicker, timepicker {
> >   color: -moz-FieldText;
> > }
> > 
> > .datetimepicker-input-subbox {
> >   width: 1.6em;
> > }
> > 
> > html|*.datetimepicker-input {
> >-  text-align: right;
> >-}
> >-
> >-html|*.datetimepicker-input:-moz-locale-dir(rtl) {
> >-  text-align: left;
> >+  text-align: end;
> > }
> 
> I wonder whether this should always be right...

No, it should be left in RTL mode, and actually this patch makes things work, because :-moz-locale-dir is not supported for HTML elements!

(I trust that removal of plugins.css is OK, it seemed to be pointing to empty-file right now.)

Comment 7

[Dão Gottwald [:dao]]

Attachment: what I'm going to land

Fixed winstripe's datetimepicker.css too, based on comment 6.

Comment 8

[(no longer active)]

(In reply to comment #7)
> Created an attachment (id=432605) [details]
> what I'm going to land
> 
> Fixed winstripe's datetimepicker.css too, based on comment 6.

Seems good!

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/69cb1df1cb0f