Add "snapToPixels" parameter to gfxContext::RoundedRectangle()

RESOLVED INVALID

Status

()

RESOLVED INVALID
10 years ago
8 months ago

People

(Reporter: dholbert, Unassigned)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

10 years ago
As suggested by roc in bug 472769 comment 31 and bug 472769 comment 36, we need to add a "snapToPixels" argument in gfxContext::RoundedRectangle (like the one in gfxContext::Rectangle) so that we can have consistent behavior between the two.
(Reporter)

Updated

10 years ago
Assignee: nobody → dholbert
(Reporter)

Comment 1

10 years ago
Created attachment 360998 [details] [diff] [review]
like so?

This patch just basically copies the snapToPixels code from "Rectangle" into "RoundedRectangle".  (setting up a snapped rect and temporarily setting mCairo to the identity matrix, and then making a recursive call)
(Reporter)

Comment 2

10 years ago
Created attachment 361034 [details] [diff] [review]
like so v2?

(Oops; prev patch doesn't compile -- I forgot to update the method signature in the .cpp file.  That's fixed in this version)
Attachment #360998 - Attachment is obsolete: true
(Reporter)

Comment 3

8 months ago
gfxContext::RoundedRectangle no longer exists, as of bug 1091787 part 3: 
 https://hg.mozilla.org/mozilla-central/rev/2b0217193d51

So this is now INVALID; nothing to be done anymore.
Assignee: dholbert → nobody
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Depends on: 1091787
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.