Closed Bug 477122 Opened 15 years ago Closed 6 years ago

Add "snapToPixels" parameter to gfxContext::RoundedRectangle()

Categories

(Core :: Layout, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: dholbert, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

As suggested by roc in bug 472769 comment 31 and bug 472769 comment 36, we need to add a "snapToPixels" argument in gfxContext::RoundedRectangle (like the one in gfxContext::Rectangle) so that we can have consistent behavior between the two.
Assignee: nobody → dholbert
Attached patch like so? (obsolete) — Splinter Review
This patch just basically copies the snapToPixels code from "Rectangle" into "RoundedRectangle".  (setting up a snapped rect and temporarily setting mCairo to the identity matrix, and then making a recursive call)
Attached patch like so v2?Splinter Review
(Oops; prev patch doesn't compile -- I forgot to update the method signature in the .cpp file.  That's fixed in this version)
Attachment #360998 - Attachment is obsolete: true
gfxContext::RoundedRectangle no longer exists, as of bug 1091787 part 3: 
 https://hg.mozilla.org/mozilla-central/rev/2b0217193d51

So this is now INVALID; nothing to be done anymore.
Assignee: dholbert → nobody
Status: NEW → RESOLVED
Closed: 6 years ago
Depends on: 1091787
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: