Port the code that uses gfxContext::RoundedRectangle to Moz2D

RESOLVED FIXED in mozilla36

Status

()

Core
Layout
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

(Blocks: 1 bug)

Trunk
mozilla36
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Comment hidden (empty)
(Assignee)

Updated

4 years ago
Depends on: 1091794
(Assignee)

Comment 1

4 years ago
Created attachment 8514461 [details] [diff] [review]
nsCSSRenderingBorders
Attachment #8514461 - Flags: review?(matt.woodrow)
(Assignee)

Comment 2

4 years ago
Created attachment 8514463 [details] [diff] [review]
nsCSSRendering
Attachment #8514463 - Flags: review?(matt.woodrow)
(Assignee)

Comment 3

4 years ago
Created attachment 8514464 [details] [diff] [review]
remove gfxContext API
Attachment #8514464 - Flags: review?(matt.woodrow)
Attachment #8514461 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8514463 [details] [diff] [review]
nsCSSRendering

Review of attachment 8514463 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsCSSRendering.cpp
@@ +1548,5 @@
>                 shadowContext == blurringArea.GetContext());
>  
>      // Set the shadow color; if not specified, use the foreground color
> +    Color shadowColor = Color::FromABGR(shadowItem->mHasColor ?
> +                                        shadowItem->mColor :

Indent this one more so it doesn't look like a second param to FromABGR.
Attachment #8514463 - Flags: review?(matt.woodrow) → review+
Attachment #8514464 - Flags: review?(matt.woodrow) → review+
(Assignee)

Comment 5

4 years ago
Comment on attachment 8514461 [details] [diff] [review]
nsCSSRenderingBorders

I had to add some fuzz for this.

https://hg.mozilla.org/integration/mozilla-inbound/rev/45638c4e2cd7
Attachment #8514461 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/45638c4e2cd7
https://hg.mozilla.org/mozilla-central/rev/e19f73842826
https://hg.mozilla.org/mozilla-central/rev/2b0217193d51
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36

Updated

4 years ago
Depends on: 1094063
Depends on: 1097119
You need to log in before you can comment on or make changes to this bug.