1091787 - Port the code that uses gfxContext::RoundedRectangle to Moz2D

Status: RESOLVED FIXED

(Core :: Layout, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: nsCSSRenderingBorders

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: nsCSSRendering

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: remove gfxContext API

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8514463 [details] [diff] [review]
nsCSSRendering

Review of attachment 8514463 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsCSSRendering.cpp
@@ +1548,5 @@
>                 shadowContext == blurringArea.GetContext());
>  
>      // Set the shadow color; if not specified, use the foreground color
> +    Color shadowColor = Color::FromABGR(shadowItem->mHasColor ?
> +                                        shadowItem->mColor :

Indent this one more so it doesn't look like a second param to FromABGR.

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 8514461 [details] [diff] [review]
nsCSSRenderingBorders

I had to add some fuzz for this.

https://hg.mozilla.org/integration/mozilla-inbound/rev/45638c4e2cd7

Comment 6

[Jonathan Watt [:jwatt]]

Comment on attachment 8514463 [details] [diff] [review]
nsCSSRendering

https://hg.mozilla.org/integration/mozilla-inbound/rev/e19f73842826

Comment 7

[Jonathan Watt [:jwatt]]

Comment on attachment 8514464 [details] [diff] [review]
remove gfxContext API

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b0217193d51

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/45638c4e2cd7
https://hg.mozilla.org/mozilla-central/rev/e19f73842826
https://hg.mozilla.org/mozilla-central/rev/2b0217193d51