477261 - Progress bar reset when switching to a tab (XULBrowserWindow.onStateChange called twice)

Status: RESOLVED INVALID

(Firefox :: Tabbed Browser, defect)

Description

[Karthik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6

I am having a slow internet connection so most pages take more time to load, when a page is loading if I switch to a different tab and return to the first tab I opened the progress bar at bottom of window resets to the beginning and starts from first. This problem is in all versions of Firefox. “Firefox is great”
                    
For better results have a very slow internet connection.

Reproducible: Always

Steps to Reproduce:
1.Open a big web page(That takes some time to load in your connection speed, for better result make your internet connection slow as my dialup).
2.Let the progress bar progress to some extent.
3.When the first page is loading open a new tab and switch to the new tab.
4.Then return to the first tab in which you opened a web page.
5.You can find that the progress bar has been reset to the beginning(The page should be still loading and should have not finished loading that is why I Suggested a slow connection and big web page)

Actual Results:  
The progress bar resets to the beginning.

Expected Results:  
The progress bar should indicate the actual progress.

This occurs in the default theme.
I am having a good PC with good speed but a very slow internet connection.

Comment 1

[Simon Bünzli]

The issue is that XULBrowserWindow.onStateChange is called twice, once from XULBrowserWindow.onUpdateCurrentBrowser and once from gBrowser.updateCurrentBrowser directly. The progress bar is updated in between, but reset due to the (incomplete) second call.

Comment 2

[Simon Bünzli]

Attachment: only call onStateChange for listeners without onUpdateCurrentBrowser

It seems that onUpdateCurrentBrowser's contract isn't all that clear. This patch assumes that it's actually supposed to handle all state related changes (state, status, progress).

BTW: The lonely change at the start makes it so that progress is stated to be 100% instead of 0% when a tab is done loading (the progress bar will be hidden, anyhow).

Comment 3

[Simon Bünzli]

Attachment: only call onStateChange for listeners without onUpdateCurrentBrowser

Same as above with the fix for bug 483895 incorporated and with immediately hiding the progress bar when switching tabs, so that the progress bar experience is finally as expected.

Comment 4

[Michael Kohler [:mkohler]]

This is a mass change. Every comment has "assigned-to-new" in it.

I didn't look through the bugs, so I'm sorry if I change a bug which shouldn't be changed. But I guess these bugs are just bugs that were once assigned and people forgot to change the Status back when unassigning.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

I believe this is no longer relevant now that we have no more progress bars.