597421 - Progress Line status inconsistent between background indicator and foreground indicator (can see when switching to tab)

Status: RESOLVED INVALID

(Firefox :: Tabbed Browser, defect)

Description

[Christian Ascheberg]

User-Agent:       Mozilla/5.0 (Windows NT 6.0; rv:2.0b7pre) Gecko/20100917 Firefox/4.0b7pre
Build Identifier: Mozilla/5.0 (Windows NT 6.0; rv:2.0b7pre) Gecko/20100917 Firefox/4.0b7pre

The status of the Progress Line below the location bar only seems to be updated on status changes, so when switching to a tab that is still loading, the Progress Line is at first always showing 0% progress, no matter what the actual progress is.

There is no such problem with the Progress Line above the tabs.

Reproducible: Always

Steps to Reproduce:
1. load website, like http://arewefastyet.com/
2. switch to another tab
3. watch Progress Line status on the tab
4. switch back to previous tab while its still loading (best when its slow/hanging at some point)
5. compare status of Progress Line below location bar to the previously shown status
Actual Results:  
Progress Line below location bar is showing 0% progress, it will only be updated to the correct status when the status changes.

Expected Results:  
Progress Line should immediately show the correct current progress status.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

This could end up looking really bad if we get a slow loading website; should poll for current position when we switch.

Comment 2

[juan becerra [:juanb]]

Here's what it looks like: http://screencast.com/t/NmI0NGVhNT

Comment 3

[:Margaret Leibovic]

I can reproduce this using a http proxy to slow down my connection, but I'm still trying to figure out exactly what's going wrong. It seems like the wrong value of listener.mTotalProgress is getting passed to the onUpdateCurrentBrowser listener here: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#805. I'm going to keep digging, but I'm welcome to suggestions if anyone knows what's going on here.

Comment 4

[:Margaret Leibovic]

Attachment: patch

Missing a parameter!

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Another good testcase, should one want to test this, is to do a MXR search on the tab that you intend to load in the background. That takes forever.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 479211 [details] [diff] [review]
patch

It would be nice to have a test for this. We'd need to either load a resource from the test server and somehow enforce that we receive multiple progress events (and do the tab switching in between them), or fake that by making calls to onProgressChange manually, but with that I think it should be doable.

Comment 9

[:Margaret Leibovic]

(In reply to comment #8)
> Comment on attachment 479211 [details] [diff] [review]
> patch
> 
> It would be nice to have a test for this. We'd need to either load a resource
> from the test server and somehow enforce that we receive multiple progress
> events (and do the tab switching in between them), or fake that by making calls
> to onProgressChange manually, but with that I think it should be doable.

Do you want me to make a test before I land this, or just make the test later?

Comment 10

[:Margaret Leibovic]

Bug 602964 makes this invalid.