Last Comment Bug 477400 - No shortcut for SeaMonkey and Thunderbird
: No shortcut for SeaMonkey and Thunderbird
Status: RESOLVED FIXED
:
Product: Other Applications
Classification: Client Software
Component: DOM Inspector (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Jens Hatlak (:InvisibleSmiley)
:
Mentors:
Depends on:
Blocks: 477844
  Show dependency treegraph
 
Reported: 2009-02-07 10:12 PST by Jens Hatlak (:InvisibleSmiley)
Modified: 2009-02-28 14:08 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
SM+TB shortcuts [Checkin: Comment 4] (1.45 KB, patch)
2009-02-07 10:15 PST, Jens Hatlak (:InvisibleSmiley)
sdwilsh: review+
philringnalda: review+
neil: superreview+
Details | Diff | Splinter Review

Description Jens Hatlak (:InvisibleSmiley) 2009-02-07 10:12:42 PST
tasksOverlay.xul (SM) and tasksOverlay-tb.xul (TB) both contain <key id="key_inspectPage">, just like tasksOverlay-ff.xul or tasksOverlay-sb.xul, but unlike the latter they contain no key="key_inspectPage" in the respective <menuitem>. Thus there is no shortcut assigned in those applications (tested only SM but looking at my explanation I'm pretty sure it also applies to TB). The one defined (Ctrl+Shift+I) doesn't seem to clash with anything already defined (again, checked only SM) so I guess this is just an oversight that should be corrected.

Patch coming up.
Comment 1 Jens Hatlak (:InvisibleSmiley) 2009-02-07 10:15:08 PST
Created attachment 361065 [details] [diff] [review]
SM+TB shortcuts
[Checkin: Comment 4]
Comment 2 Shawn Wilsher :sdwilsh 2009-02-10 10:31:25 PST
Comment on attachment 361065 [details] [diff] [review]
SM+TB shortcuts
[Checkin: Comment 4]

r=sdwilsh
Comment 3 neil@parkwaycc.co.uk 2009-02-11 04:21:11 PST
Comment on attachment 361065 [details] [diff] [review]
SM+TB shortcuts
[Checkin: Comment 4]

>   <keyset id="tasksKeys">
>     <key id="key_inspectPage" key="i" modifiers="accel,shift" command="Tasks:InspectPage"/>
>   </keyset>
>   
>   <menupopup id="toolsPopup">
>-    <menuitem id="menu_inspector" label="&inspectorTaskCmd.label;" 
>+    <menuitem id="menu_inspector" label="&inspectorTaskCmd.label;" key="key_inspectPage"
>               accesskey="&inspectorTaskCmd.accesskey;" command="Tasks:Inspector"/>
>   </menupopup>
Interestingly the key's command is Tasks:InspectPage while the menuitem's command is Tasks:Inspector (and I quite like to have the choice, so I'd rather not use Firefox's solution of making them both InspectPage). Mind you, we do have a smallish precedent with the compose window where pressing Ctrl+Return will prompt for confirmation but clicking the menuitem with that label won't.
Comment 4 Serge Gautherie (:sgautherie) 2009-02-26 09:06:40 PST
Comment on attachment 361065 [details] [diff] [review]
SM+TB shortcuts
[Checkin: Comment 4]


http://hg.mozilla.org/dom-inspector/rev/a5e39890d1ab
Comment 5 Jens Hatlak (:InvisibleSmiley) 2009-02-28 14:08:48 PST
This was not working for me until I realized that some third-party software had already taken control over the Ctrl+Shift+I shortcut (in my case it was Miranda but  there are probably more applications reserving shortcuts globally, e.g. Trillian).

Note You need to log in before you can comment on or make changes to this bug.