No shortcut for SeaMonkey and Thunderbird

RESOLVED FIXED

Status

Other Applications
DOM Inspector
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
tasksOverlay.xul (SM) and tasksOverlay-tb.xul (TB) both contain <key id="key_inspectPage">, just like tasksOverlay-ff.xul or tasksOverlay-sb.xul, but unlike the latter they contain no key="key_inspectPage" in the respective <menuitem>. Thus there is no shortcut assigned in those applications (tested only SM but looking at my explanation I'm pretty sure it also applies to TB). The one defined (Ctrl+Shift+I) doesn't seem to clash with anything already defined (again, checked only SM) so I guess this is just an oversight that should be corrected.

Patch coming up.
(Assignee)

Comment 1

9 years ago
Created attachment 361065 [details] [diff] [review]
SM+TB shortcuts
[Checkin: Comment 4]
Assignee: nobody → jh
Status: NEW → ASSIGNED
Attachment #361065 - Flags: review?
(Assignee)

Updated

9 years ago
Attachment #361065 - Flags: review? → review?(sdwilsh)
Comment on attachment 361065 [details] [diff] [review]
SM+TB shortcuts
[Checkin: Comment 4]

r=sdwilsh
Attachment #361065 - Flags: superreview?(neil)
Attachment #361065 - Flags: review?(sdwilsh)
Attachment #361065 - Flags: review+

Updated

9 years ago
Blocks: 477844

Comment 3

9 years ago
Comment on attachment 361065 [details] [diff] [review]
SM+TB shortcuts
[Checkin: Comment 4]

>   <keyset id="tasksKeys">
>     <key id="key_inspectPage" key="i" modifiers="accel,shift" command="Tasks:InspectPage"/>
>   </keyset>
>   
>   <menupopup id="toolsPopup">
>-    <menuitem id="menu_inspector" label="&inspectorTaskCmd.label;" 
>+    <menuitem id="menu_inspector" label="&inspectorTaskCmd.label;" key="key_inspectPage"
>               accesskey="&inspectorTaskCmd.accesskey;" command="Tasks:Inspector"/>
>   </menupopup>
Interestingly the key's command is Tasks:InspectPage while the menuitem's command is Tasks:Inspector (and I quite like to have the choice, so I'd rather not use Firefox's solution of making them both InspectPage). Mind you, we do have a smallish precedent with the compose window where pressing Ctrl+Return will prompt for confirmation but clicking the menuitem with that label won't.
Attachment #361065 - Flags: superreview?(neil) → superreview+
(Assignee)

Updated

9 years ago
Attachment #361065 - Flags: review?(philringnalda)
Attachment #361065 - Flags: review?(philringnalda) → review+
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
Comment on attachment 361065 [details] [diff] [review]
SM+TB shortcuts
[Checkin: Comment 4]


http://hg.mozilla.org/dom-inspector/rev/a5e39890d1ab
Attachment #361065 - Attachment description: SM+TB shortcuts → SM+TB shortcuts [Checkin: Comment 4]
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
(Assignee)

Comment 5

9 years ago
This was not working for me until I realized that some third-party software had already taken control over the Ctrl+Shift+I shortcut (in my case it was Miranda but  there are probably more applications reserving shortcuts globally, e.g. Trillian).
You need to log in before you can comment on or make changes to this bug.