47743 - Copy should be added to e-mail address context menu

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[Henrik Gemal]

When you right-click on a e-mail address in the header field of the messagepane, 
Copy should appear in the context menu.

Currently the context menu only has:
 Add address to address book
 Send mail to

The Copy would copy the email address to the clipboard.

Comment 1

[scottputterman]

moving to future milestone and reassigning to mscott.

Comment 2

[Jesse Ruderman]

I think this context menu should share menu items with the mailto: link context 
menu in bug 32358.  Then we'd automatically have the same mnemonics in both 
menus, and internationalization teams would have fewer things to translate.

See also discussion in bug 57578 about removing this context menu :(

Comment 3

[Matthew T (active 1999-2002)]

The context menu for these addresses should be the same as for any other e-mail 
address link in a Web page or e-mail message -- though the default item would be 
different (`Add to Address Book ...' for an address in the header pane, vs. `New 
Message' in Web page/message content).

Bug 57578 isn't about removing the context menu, it is about turning the current 
compulsory menu into a context menu.

Comment 4

[scottputterman]

nominating nsbeta1 to add copy to the menu.

Comment 5

[scottputterman]

marking nsbeta1-

Comment 6

[Boris Zbarsky [:bzbarsky]]

*** Bug 54894 has been marked as a duplicate of this bug. ***

Comment 7

[Boris Zbarsky [:bzbarsky]]

*** Bug 63023 has been marked as a duplicate of this bug. ***

Comment 8

[Gervase Markham [:gerv]]

OK - patches coming right up. I would appreciate review of these :-) 

Resetting target milestone and nsbeta1 nomination for retriage...

Hope they work - my editor does funny things with the tabs in the file, so 
there's been a little hand-hackery of the patches.

Gerv

Comment 9

[Gervase Markham [:gerv]]

Attachment: Patches to content files

Comment 10

[Gervase Markham [:gerv]]

Attachment: Patch to US DTD

Comment 11

[Adam Lock]

Code looks okay to me, but the documentation for CopyEmailAddress is incorrect.

r=adamlock

Comment 12

[Gervase Markham [:gerv]]

Thanks! :-) Fixed. Now who do I go to for an sr=?

Gerv

Comment 13

[scottputterman]

marking nsbeta1-, but of course, since Gervase has a patch it would be cool if
this got in.

Comment 14

[R.K.Aa.]

*** Bug 73616 has been marked as a duplicate of this bug. ***

Comment 15

[Gervase Markham [:gerv]]

Attachment: Updated diff - looking for sr=

Comment 16

[Jesse Ruderman]

Oops, this bug doesn't block bug 32358, since for now the context menu for e-
mail addresses in mailnews xul is different from the context menu for e-mail 
addresses in html content.

Comment 17

[timeless]

r=timeless

Comment 18

[Gervase Markham [:gerv]]

sspitzer - any chance of a sr= here? :-) 

[ Sidenote: you and dveditz get the prize for the people whose name is most 
often misspelt in checkin comments...]

Gerv

Comment 19

[Gervase Markham [:gerv]]

Attachment: New patch - old one had rotted slightly

Comment 20

[Alec Flett]

sr=alecf assuming we get approval/review from a mail person

Comment 21

[Gervase Markham [:gerv]]

sspitzer, mscott or bienvenu: This bug has r= and sr=, it just needs a "Yes,
we'd like that" from someone in mail/news. Can that be provided?

I know Asa wants this really badly ;-)

Gerv

Comment 22

[Asa Dotzler [:asa]]

I'd like to see this land for 0.9 if mail-news folks are OK with it. 

Comment 23

[David :Bienvenu]

fine with me, if that's sufficient.

Comment 24

[Gervase Markham [:gerv]]

It just needs someone to check it in, then. I can't, and I'm going to bed anyway
:-)

Gerv

Comment 25

[timeless]

fix by Gervase Markham mailto:[e-mail] checked in. Sorry 
gerv i messed up the cvs comment.

If anyone has any problems with this bug please open a new one against gerv or 
me cc the other and cite this bug. I'm very sorry.

Comment 26

[laurel]

OK using apr23 commercial trunk build. Win98, linux rh6.2, mac OS 9.0
Context menu item present and functional from mail and news header envelopes.
Any other issues with this item will be logged separately.