477457 - advanced search add-on types are mixed up

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[singingotter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6 (.NET CLR 2.0.50727; .NET CLR 3.0.04506.30; .NET CLR 3.0.04506.648; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6 (.NET CLR 2.0.50727; .NET CLR 3.0.04506.30; .NET CLR 3.0.04506.648; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)

Search for 'type:plug-in' yields Language packs, search for 'type:Language packs(application)' gives plugins.

Reproducible: Always

Steps to Reproduce:
1.goto <tools-add-ons-browse all add-ons-serch for add-ons (advanced)>
2.select type:plug-in' (yields Language packs), or 'type:Language packs(application)
3.
Actual Results:  
Search for 'type:plug-in' yields Language packs, search for 'type:Language packs(application)' gives plugins.

Expected Results:  
Search for 'type:plug-in' yields plugins, search for 'type:Language packs(application)' gives Language packs.

Comment 1

[Dave Garrett]

Confirmed. This seems to be quite screwed up right now.

Advanced search types are showing as:
Dictionary -> Extensions
Extension -> Themes
Language Pack (Add-on) -> Dictionaries
Language Pack (Application) -> Search Plugins
Plugins -> Application Language Packs

Comment 2

[Dave Garrett]

Looks like someone changed the labels without changing what types they search for. The preview.addons.mozilla.org server has the right-side labels in comment 1 and works fine.

Comment 3

[Dave Garrett]

I think this is caused by the changes from bug 377513.

Comment 4

[Wil Clouser [:clouserw]]

(In reply to comment #3)
> I think this is caused by the changes from bug 377513.

Nothing in that bug has landed on production, that's not the cause.  Coincidentally, it does fix this though.

This appears to be caused by using asort() in Addontype::getNames() instead of ksort().  asort() was added on May 29, 2008. :(

Comment 5

[Dave Garrett]

I don't think this has been broken since last May, has it?...

Comment 6

[u278084]

If so, I think we have one feature we should remove ;)

Comment 7

[Kevin Brosnan]

I know I've used the feature more recently than last May and it behaved correctly.

Comment 8

[Wil Clouser [:clouserw]]

This is fixed on trunk right now (https://preview.addons.mozilla.org/) due to bug 377513.  I'll mark this "push-needed" and next week it should be in production.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on production, due to tonight's push.