Closed Bug 477512 Opened 11 years ago Closed 11 years ago

TestHarness.h should print the magic keywords for making failures show up in the tinderbox log

Categories

(Testing :: XPCShell Harness, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

Attachments

(2 files)

TestHarness.h has code to print info about failures.  However, it just prints "FAIL", which isn't enough to make it show in the tinderbox log highlighting.  It should instead print TEST-UNEXPECTED-FAIL.

http://mxr.mozilla.org/mozilla-central/source/xpcom/tests/TestHarness.h

This was an issue when bug 88831 about 36 hours ago.

We might also want to check other TUnit tests.
Attached patch patchSplinter Review
Bug 477867 limited my testing a little bit, but it seems to work fine.
Attachment #361597 - Flags: review?(jwalden+bmo)
Attachment #361597 - Flags: review?(jwalden+bmo) → review+
Duplicate of this bug: 468033
Assignee: nobody → dbaron
And I'll fix the comment too.
Comment on attachment 361657 [details] [diff] [review]
fix the pass function too

Hm, how'd I forget this part too?
Attachment #361657 - Flags: review?(jwalden+bmo) → review+
http://hg.mozilla.org/mozilla-central/rev/af294f0d2c6a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Can you land this on 1.9.1 too?
You need to log in before you can comment on or make changes to this bug.