477512 - TestHarness.h should print the magic keywords for making failures show up in the tinderbox log

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

TestHarness.h has code to print info about failures.  However, it just prints "FAIL", which isn't enough to make it show in the tinderbox log highlighting.  It should instead print TEST-UNEXPECTED-FAIL.

http://mxr.mozilla.org/mozilla-central/source/xpcom/tests/TestHarness.h

This was an issue when bug 88831 about 36 hours ago.

We might also want to check other TUnit tests.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Bug 477867 limited my testing a little bit, but it seems to work fine.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: fix the pass function too

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And I'll fix the comment too.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/561dc7d5c746

Comment 6

[Jeff Walden [:Waldo]]

Comment on attachment 361657 [details] [diff] [review]
fix the pass function too

Hm, how'd I forget this part too?

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/af294f0d2c6a

Comment 8

[(not currently active) Ted Mielczarek]

Can you land this on 1.9.1 too?

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/225b2acca344
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/52c7f8c43bbd