47762 - Installer switches focus to itself repeatedly

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect, P4)

Description

[cpratt]

Build ID:   

ftp://sweetlou/products/client/seamonkey/windows/32bit/x86/2000-08-04-05-M17/

(repacked pr2 bits)

To reproduce:

- Launch the installer
- As Smart Download starts to pull the files down from the server, switch to 
another app to continue your work during the download.

Result: Repeatedly, focus is switched back to Smart Download. This is 
aggravating as you must repeatedly switch back to the other app to continue your 
work. Ideally there would be no focus switching so that you can download the 
.xpi files in the background.

Comment 1

[Grace Bush]

this is commercial installer- changing QA contact

Comment 2

[lchiang]

This isn't specific to WinME, is it?

Comment 3

[cpratt]

As far as I know this happens on all Win32 platforms. IIRC this definitely 
happens on Windows 98 (at least).

Comment 4

[Henrik Gemal]

I'm marking this a dup of 65031.
If this is also a problem with smartdownload please file bug with bugscape, 
since mozilla doesn't use smartdownload.

*** This bug has been marked as a duplicate of 65031 ***

Comment 5

[cpratt]

This bug was filed almost half a year earlier; therefore, it's not a duplicate 
of a later bug.

Comment 6

[cpratt]

*** Bug 65031 has been marked as a duplicate of this bug. ***

Comment 7

[Henrik Gemal]

It was instead of moving this to INVALID....:) since smartdownload != mozilla

Comment 8

[Henrik Gemal]

*this bug is not about smartdownload*

Since my bug has to be a dupe of this bug carrying over comments:
After the new installer (the one without the blue background) the installer 
keeps taken focus when installing. This is because the constant use of "close 
status window, open new status window".

Reproduce:
After pressing Install the installation begins. If you try to set focus on a 
nother application suddenly the installer window gets focus. This is happening 
quite a few times.
It's properbly because the new installer windows dont have any "parent" window 
but are new window, not modular to anything.

Comment 9

[Aaron Leventhal]

This will cause problems for assistive technology users.

Comment 10

[Aaron Leventhal]

This will cause problems for assistive technology users.

Comment 11

[Sean Su]

over to Curt.

Comment 12

[Syd Logan]

only nsbeta1+ bugs can have milestones, resetting to ---

Comment 13

[José Jeria]

*** Bug 205303 has been marked as a duplicate of this bug. ***

Comment 14

[Jason Bassford]

Resetting milestone.  (This isn't, at least any longer, an nsbeta1+ bug.)

Also changing severity back to normal.  There is no easy workaround for this -
it simply prevents you from doing any other work during the time that the
install takes place.

Reassigning bug to defaults of component, since I believe that the Netscape
people are no longer appropriate.

Comment 15

[S Iyer]

(In reply to comment #14)
> Also changing severity back to normal.  There is no easy workaround for this -
> it simply prevents you from doing any other work during the time that the
> install takes place.

This may sound like a flame but... for some people "doing any other work" is
actually somewhat important.  Mainly due to this annoyance, I have stopped
downloading the nightly releases and now only upgrade at the milestones, i.e.
you lost one tester.

I fail to understand why there is no easy solution. Surely, it is possible to
create one parent window and make everything else its child?

Comment 16

[Sean Su]

Attachment: patch v1.0

This patch will stop the focus stealing.  The only awkwardness is that the GRE
installer runs in "AUTO" mode (show dialogs that does not require user
intevention).  This mode still shows dialogs, which the mozilla installer has
no control over.

One option is to have the GRE installer run in silent mode.  This would be a
trivial patch.

This patch seems to be doing the trick for me.	Could someone try out the
patch?

Comment 17

[Daniel (Leaf) Nunes]

r=leaf, i say you check in, and we can test the subsequent tinderbox build.
cc'ing asa for a=, since we're in a freeze.

Comment 18

[Asa Dotzler [:asa]]

w00t! let's get this in :-)

Comment 19

[Daniel Veditz [:dveditz]]

Comment on attachment 152390 [details] [diff] [review]
patch v1.0

r= (or sr=) dveditz.

ClosePreviousDialog() would be clearer than  CloseLastDialog()--which can mean
"final" dialog--but it's up to you on that.

Comment 20

[Sean Su]

Attachment: patch v1.1

changed CloseLastDialog() to ClosePreviousDialog().

Comment 21

[Sean Su]

patch v1.1 checked in to trunk only.  Dveditz will be applying the patch to the
various branches.

Comment 22

[Sean Su]

Attachment: patch v2.0

I recommend that this patch also be applied.  It makes the gre installer run in
silent mode.

The GRE installer is currently running in "AUTO" mode where it shows dialogs
all dialogs that do not require user input.  Since GRE has it's own installer
(seperate app), it's dialogs will appear in the foreground, taking focus from
whatever app was in the foreground.

Applying this patch will make the GRE installer run in silent mode (no
dialogs).  This allows the Mozilla installer's dialog to be the only dialog
displayed, thus not taking focus from any other app.

Comment 23

[Daniel Veditz [:dveditz]]

Comment on attachment 152585 [details] [diff] [review]
patch v2.0

r=dveditz (or sr= if desired)

Comment 24

[Sean Su]

patch 2.0 landed.

Comment 25

[Asa Dotzler [:asa]]

Comment on attachment 152585 [details] [diff] [review]
patch v2.0

a=asa

Comment 26

[Asa Dotzler [:asa]]

I don't believe this is a problem for the aviary products. Removing aviary
nomination.

Comment 27

[Sander]

I suspect this to have caused bug 264461.

Comment 28

[Andrew Schultz]

this apparently also caused bug 264980

Comment 29

[Asa Dotzler [:asa]]

1.7.5 has shipped. Moving request to 1.7.6.

Comment 30

[chris hofmann]

closing down to release 1.7.6  -minus

Comment 31

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) <dialogs.c> (1/2)

(1/2) Followup to patch v1.1: (found in bug 264980 comment 29)
1 unused (= leftover) var + 2 nits.

Comment 32

[Serge Gautherie (:sgautherie)]

Dan, (or Sean !):
Could you have a look at my question in bug 264980 comment 42 (and previous) ?
Thanks.

Comment 33

[Daniel Veditz [:dveditz]]

Comment on attachment 188881 [details] [diff] [review]
(Cv1) <dialogs.c> (1/2)

r=dveditz

Comment 34

[Serge Gautherie (:sgautherie)]

Comment on attachment 188881 [details] [diff] [review]
(Cv1) <dialogs.c> (1/2)

'approval1.8b4=?': (SeaMonkey only)
Trivial Installer code cleanup, no risk.

Comment 35

[Serge Gautherie (:sgautherie)]

Comment on attachment 188881 [details] [diff] [review]
(Cv1) <dialogs.c> (1/2)


Check in: { 2005-08-03 09:28	neil%parkwaycc.co.uk	mozilla/ xpinstall/
wizard/ windows/ setup/ dialogs.c   1.96 }

Comment 36

[Serge Gautherie (:sgautherie)]

Attachment: (Dv1) <dialogs.c> (2/2)

Read bug 264980 comment 42 (and previous) for rationale.

Comment 37

[Steffen Wilberg]

Comment on attachment 194029 [details] [diff] [review]
(Dv1) <dialogs.c> (2/2)

I guess this is not relevant anymore.