477697 - Decorate site button (larry) based on level of cert

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

The site button should visibly change (ideally with a size change so that there is eye-drawing movement) when the current site has an SSL or EV cert, as happens in desktop firefox.  For example, some mockups of this for EV (using the colors as they're used in firefox):

http://blog.seanmartell.com/wp-content/uploads/2008/09/fennec_screen_9.jpg
and
http://blog.seanmartell.com/wp-content/uploads/2008/09/fennec_screen_10.jpg

Gavin - I think you have the most recent version of the images?

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

How do you feel about keeping the color change but dropping the addition of "larry" next to the favicon? It could be a performance issue (we already re-arranged the code there once for perf)

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: images

These aren't that recent, but these are the images I got from Sean for one of the previous theme updates.

Comment 3

[Madhava Enros [:madhava]]

re: comment 1

I think that would be fine, given that it would save space.  I would like to see the button get a little bigger (even a few pixels wider) when we switch colours, even if we're not adding larry, because movement there (as in something getting wider) is much more noticeable than just a colour change.  That's part of the rationale for adding the TLD or org name in the desktop firefox version.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Should we make this work part of the new theme?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: WIP - the basics

This simple CSS change is the basic change we'll need to tweak the identity button. I think I'll wait for the new theme to add the color itself.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

This landed with the dark theme (bug 491301). Add any theme change tweaks to
bug 491627.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

verified fixed in 20091001 1.9.2 b4 on my n810