477842 - Text boxes containing domains and URLs should stay LTR when UI is RTL

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[(no longer active)]

This is a clone of bug 213727 which covers the SeaMonkey issue.  The text boxes which contain domain and URL data should stay LTR when the UI is RTL.  This can be done by adding a uri-element class on their respective XUL element.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Fixes the mail start page field and the plain/html domain fields. That's all the fields i found.

Comment 2

[Phil Ringnalda (:philor)]

Ehsan: what's your feeling about proxy settings? Looks like they haven't been done in Firefox, but I'm not sure why not.

Also, do we need to force LTR in read-only textboxes? There are a couple (feed subscriptions and folder properties) in mailnews, but I've never been quite sure whether uri-element is just about what happens when you type, or also about read-only display.

Magnus: someone's going to have to claim ownership of http://mxr.mozilla.org/comm-central/source/mailnews/extensions/newsblog/content/feed-properties.xul#81, might as well be us instead of SeaMonkey.

Comment 3

[(no longer active)]

(In reply to comment #2)
> Ehsan: what's your feeling about proxy settings? Looks like they haven't been
> done in Firefox, but I'm not sure why not.

Technically they should be LTR only as well.  Is the dialog inside toolkit?  If so, then Firefox would benefit from the fix.

> Also, do we need to force LTR in read-only textboxes? There are a couple (feed
> subscriptions and folder properties) in mailnews, but I've never been quite
> sure whether uri-element is just about what happens when you type, or also
> about read-only display.

AFAIU, there is no difference between read-only and normal textboxes as far as uri-element is concerned; the class should be specified on both types.

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 387697 [details] [diff] [review]
proposed fix

No, proxy settings are copy-pasted, which is fortunate for us since that means we don't have to fight for a stable-branch landing.

The rest looks good to me, but you'll probably want to hit up Standard8 for the expanded patch, to dot your t's for the mailnews/ parts.

Comment 5

[Magnus Melin [:mkmelin]]

So how about the "No proxies for: " field? 
That's hosts, comma separated. Should that always be LTR too?

Comment 6

[Tomer Cohen :tomer]

I'd like to suggest categorizing every input field that should be always LTR with some class, or even specify class name by the expected content, so we will be able to add something like the following to the default theme CSS files -

  .host, .email, .address { direction: ltr !important; }

Comment 7

[(no longer active)]

(In reply to comment #5)
> So how about the "No proxies for: " field? 
> That's hosts, comma separated. Should that always be LTR too?

Yes.

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Also fix proxies, folder properties location, feed subscription dialog.
The feed subscriptions dialog change does look a bit odd testing with the force ltr extension, but on the other hand, it all looks fairly odd ;)

Comment 9

[Phil Ringnalda (:philor)]

Comment on attachment 388996 [details] [diff] [review]
proposed fix

That seems to be everything I saw, thanks!

Comment 10

[Magnus Melin [:mkmelin]]

changeset:   3335:e117ab243cb8
http://hg.mozilla.org/comm-central/rev/e117ab243cb8

->FIXED