477862 - Activity Manager: activity list doesn't clear permanently until restart

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mark Banner (:standard8)]

If you click the clear button on the activity manager list, then close and reopen the window, the list reappears.

Comment 1

[klonos]

yep, i confirm this one for b3pre

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081113 Shredder/3.0b1pre

Comment 2

[Mark Banner (:standard8)]

David/Bryan/Emre: any idea why the clear button was only implemented for per display clear rather than a complete clear?

It seems the code was changed from the download manager behaviour and I'm wondering if it was intentional or not.

Comment 3

[David Ascher (:davida)]

Nah, it should probably be a db-level clear, not a visual clear.

Comment 4

[Mark Banner (:standard8)]

Attachment: The fix

Clear anything from the database (and hence display) that isn't in progress, paused or waiting for input/retry.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 365405 [details] [diff] [review]
The fix

Looks good to me! r=mkmelin

+  // If/when we implement search, we'll want to remove just the items that
+  // are on the search display, however for now, we'll just clear up everything.
>+  Components.classes["@mozilla.org/activity-manager;1"]
>+    .getService(Components.interfaces.nsIActivityManager)
>+    .cleanUp();

Nit: classes and getService aren't aligned

Comment 6

[Mark Banner (:standard8)]

Checked in with nit addressed: http://hg.mozilla.org/comm-central/rev/36423d81646f