Hg Account Request - Zack Weinberg <zweinberg@mozilla.com>

RESOLVED FIXED

Status

RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: zwol, Assigned: phong)

Tracking

Details

(Whiteboard: ssh-key, form, voucher1, voucher2, sr)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Created attachment 361853 [details]
ssh public key

I am requesting commit access to Mercurial (CVS access would also be useful).  I have not yet lined up vouchers, but I did hand in a committer's agreement some time ago.  SSH public key is attached.
Erica, please confirm you have a form on file for Zack.
Summary: requesting hg account for zweinberg@mozilla.com → Hg Account Request - Zack Weinberg <zweinberg@mozilla.com>
Whiteboard: ssh-key
I vouch. You can request dbaron to be your SR. The sticking point is going to be the non-MoCo requirement...
sr=dbaron ... although I'd note that there was at least one case (it would probably take me a while to find it) where Zack marked a patch as checkin-needed that really needed another round of review (and roc had some substantive review comments on it when it did).  With actual checkin access, you need to be more careful about that since there isn't a committer around to catch it.  (That said, I think we as reviewers probably need to be more explicit about that... I try to use review+ to mean that I don't need to look at it again and review- to mean that I do.)
(Reporter)

Comment 4

10 years ago
(In reply to comment #3)
> ... there was at least one case (it would
> probably take me a while to find it) where Zack marked a patch as
> checkin-needed that really needed another round of review (and roc had some
> substantive review comments on it when it did).

I remember that incident.  I'd like to think I've learned better :-)

Comment 5

10 years ago
I have a form for Zack on file.
Whiteboard: ssh-key → ssh-key, form, voucher1, sr
Zack, for the sake of non-MoCo approval, can you attach a list of bugs that you worked on for which fixes were landed? 5-10 should be plenty, the more interesting the better.
(Reporter)

Comment 7

10 years ago
Gah, I totally flaked on this request.  Here's a selective list.  There's a longer one at the end of https://wiki.mozilla.org/User:Zack but I haven't updated that page in some time.

363706 	CSS3 'ch' unit
311616  CSS2.1 EOF handling (most cases)
441469 	parsing of @font-face
456147 	XUL textbox strikethrough bugs
450652 	style system changes for CSS3 (elliptical) border-radius 
168117 	Need to implement nsIWidget::SetParent on the Mac
455105 	IsSolidBorderEdge in nsCSSRendering.cpp ignores foreground borders
228856 	safe handling of \0 in CSS
416907 	Crash [@ nsHTMLFramesetFrame::Reflow] with frameset in mroot
470250 	Middle part of border-image doesn't show when all border-widths are 0
455364 	border-image artifacts
459148 	SVG ellipses are drawn differently than CSS ellipses
(Reporter)

Comment 8

9 years ago
So the new rule is "two vouchers and an SR who hasn't reviewed my patches before".  That disqualifies dbaron's SR - would you be willing to treat that as a voucher instead?

Looking through the SR list, I have this bad feeling that most of them have at least been cc:ed on my bugs :-/  Maybe dmose or cbiesinger?
Being cc'ed doesn't count - the rules don't say "must not know your name, and must express surprise on being told that you've written a patch." Don't borrow trouble.
(Reporter)

Comment 10

9 years ago
Was waiting for more responses to comment 8, but it doesn't seem like that's happening ...

dbaron: Would you be willing to switch your sr to a regular voucher?

dmose/biesi: Would you consider sr'ing this request?
Don't forget mconnor: since the whole thing is his fault, he's a prime candidate to guilt into doing it.
(Reporter)

Comment 12

9 years ago
Which whole thing do you mean?
The whole new account approval system, which calls for you to find a superreviewer who both knows nothing about you and is willing to spend the time, presumably by reading all of your 67 fixed bugs, to find out enough to make a decision about you.
(In reply to comment #13)
(-1, Troll)  At least in this case he's got more options, not just "pretty much has to be biesi. ;)

sr=me, time to make Zack suck up the committing pain like the rest of us.
(In reply to comment #10)
> dbaron: Would you be willing to switch your sr to a regular voucher?

Sure.

Please remember to write good commit messages, though, and include reviewers at the end of them.
Over to server ops for HG account creation. If you want CVS access you can either file a new bug or let it be known in this bug that you want it for sure. Thanks.
Assignee: marcia → server-ops
(Reporter)

Comment 17

9 years ago
I don't need CVS right now.
(Assignee)

Updated

9 years ago
Assignee: server-ops → phong
(Assignee)

Comment 18

9 years ago
added to hg_mozilla
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Granted hg_mozsrc as well.
Whiteboard: ssh-key, form, voucher1, sr → ssh-key, form, voucher1, voucher2, sr

Updated

9 years ago
Component: Account Request: Hg → Repository Account Requests
QA Contact: hg-acct-req → repo-acct-req
You need to log in before you can comment on or make changes to this bug.