478106 - [W-1.5.4] Account Settings

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Justin Scott [:fligtar]]

Per the spec, there should be a new tab in the user's account to control collections-related preferences.

Comment 1

[Justin Scott [:fligtar]]

Attachment: mockup, v1

Mockup of the new tab.

Comment 2

[Justin Scott [:fligtar]]

This is ready for implementation. The tabs are getting a bit crowded, so I merged the change email and password tabs into one.

Comment 3

[Justin Scott [:fligtar]]

Moving to revised M5 milestone (4/28).

Comment 4

[Fred Wenzel [:wenzel]]

Attachment: SQL

SQL changes for the users table. Grab a coffee, it'll take awhile.

Comment 5

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

Account settings, incl. l10n. Note that I built this on top of the collection management patch. While the two don't share code, if the patch does not apply cleanly, that's why. If there are any problems, please let me know.

Comment 6

[Justin Scott [:fligtar]]

Ryan, can you review this soon?

Comment 7

[Ryan Doherty (:rdoherty)]

Comment on attachment 374459 [details] [diff] [review]
Patch, rev. 1

Looks good and works. It didn't merge well for me because the patch has sat around for a while, but I was able to manually update.

Comment 8

[Fred Wenzel [:wenzel]]

Committed to r25723. I also added the new columns to remora.sql.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

This requires SQL to be run on preview before it's testable, right?  Checkboxes aren't persisting their checked state for me.

Comment 10

[Fred Wenzel [:wenzel]]

Yes, the SQL hasn't been run yet. Maybe we should file a bug to have the current pile of SQL executed on preview.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; checkboxes are persisting on https://preview.addons.mozilla.org/en-US/firefox/users/edit, and the page is restyled.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"