478160 - @namespace 'a b' results in serialization weirdness

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P4)

Description

[Jesse Ruderman]

Attachment: testcase -- outputs PASS or FAIL

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yeah, we probably need to put quotes around the contents of the url().

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I have patches for this in my queue (two of them, though there's really more that needs to be done, although that's probably covered by other bugs), but I need to write tests for them at some later point.

(My queue is at http://hg.mozilla.org/users/dbaron_mozilla.com/patches/ , and the patches are escape-string-should-append and quote-and-escape-url .)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 1: refactor nsStyleUtil::EscapeCSSString into nsStyleUtil::AppendEscapedCSSString

This simplifies a lot of callers of this function, including future ones (I'm going to add more, and not only in this bug).

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 2: serialize all url() in quoted form, and escape the strings properly

This fixes this bug.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 365615 [details] [diff] [review]
patch 2: serialize all url() in quoted form, and escape the strings properly

> nsROCSSPrimitiveValue::GetEscapedURI(nsIURI *aURI, PRUnichar **aReturn)
>+  // XXX Should this reuse nsStyleUtil::AppendEscapedCSSString?

Please.  And get rid of this function altogether.

r+sr=bzbarsky

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/5a21d2b181e9
http://hg.mozilla.org/mozilla-central/rev/1ff736fd5e41

Comment 7

[Mark Smith [:mcs]]

I just spent part of a day tracking down a problem in an older extension (I did not write the original code).  It turns out that the code assumed that getComputedStyle() would NOT return quotes within url() values but because of this bug fix that is not a valid assumption in Firefox 3.6.

I added a note to the end of this section:
  https://developer.mozilla.org/en/Firefox_3.6_for_developers#DOM

Is more documentation needed somewhere?  I suspect this change will affect other pages and extensions too....

Comment 8

[Tero Turtiainen]

(In reply to comment #7)
> I suspect this change will affect other pages and extensions too....

Like the N900 mobile version of Google Images. See bug 537218.