478443 - Alter makefiles slightly to make pymake happy

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

Attachment: fix makefiles for pymake, rev. 1

pymake has slightly different rules for how dependencies are calculated, and doesn't have an implicit definition of $(RM). Both of these are easily avoided.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 362246 [details] [diff] [review]
fix makefiles for pymake, rev. 1

-jsopcode.h jsopcode.cpp: jsopcode.tbl

Does this change behavior at all, or is it effectively a no-op?

Comment 2

[Benjamin Smedberg]

It's a no-op: there's no command to remake jsopcode.h (or jsopcode.tbl) so the rule is effectively meaningless.

Comment 3

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/d17cb4c725bd

Comment 4

[Benjamin Smedberg]

And http://hg.mozilla.org/mozilla-central/rev/301fedc33749 followup: something about the ordering of cross-compiles with -j4 means we were trying to create the dist/include/js directory before nsinstall was avaialable. deps suck

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 362246 [details] [diff] [review]
fix makefiles for pymake, rev. 1

Ben, this config.mk hunk; appears to never have been committed; is that intended, or just a missed bit?

(Though it also seems unrelated from reading this bug)

Comment 6

[Benjamin Smedberg]

It was debugging code that I removed before checkin.