Port |Bug 478443 -- Alter makefiles slightly to make pymake happy| to comm-central

RESOLVED FIXED in Thunderbird 3.1b1

Status

--
trivial
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Callek, Assigned: sgautherie)

Tracking

Trunk
Thunderbird 3.1b1
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
+++ This bug was initially created as a clone of Bug #478443 +++

pymake has slightly different rules for how dependencies are calculated, and doesn't have an implicit definition of $(RM). Both of these are easily avoided.

For this port I'm only worried about the $RM stuff...
(Assignee)

Updated

9 years ago
Assignee: nobody → sgautherie.bz
Blocks: 506493, 492026
Severity: normal → trivial
OS: Linux → All
Hardware: x86 → All
Target Milestone: --- → Thunderbird 3.1b1
(Assignee)

Updated

9 years ago
Status: NEW → ASSIGNED
Flags: in-testsuite-
(Assignee)

Comment 1

9 years ago
Created attachment 426147 [details] [diff] [review]
(Av1) Just copy it
[Checkin: Comment 4]
Attachment #426147 - Flags: review?(bugspam.Callek)
(Reporter)

Updated

9 years ago
Attachment #426147 - Flags: review?(bugspam.Callek) → review+
(Reporter)

Comment 2

9 years ago
upon looking at the previous bug again (and closer) the config/config.mk actually might be useful, but is not required. [just has better error output]
(Assignee)

Comment 3

9 years ago
(In reply to comment #2)
> "previous bug" ... "config/config.mk"

Which bug? Which changeset?
(Assignee)

Comment 4

9 years ago
Comment on attachment 426147 [details] [diff] [review]
(Av1) Just copy it
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/a8155e4a4b06
Attachment #426147 - Attachment description: (Av1) Just copy it → (Av1) Just copy it [Checkin: Comment 4]
(Assignee)

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

9 years ago
(In reply to comment #3)
> (In reply to comment #2)
> > "previous bug" ... "config/config.mk"
> 
> Which bug? Which changeset?

Hmm.. I was talking about 

https://bugzilla.mozilla.org/attachment.cgi?id=362246&action=diff

But it seems the config.mk change isn't part of the changesets listed as checkin.. I'll have to look further
(Reporter)

Comment 6

9 years ago
(In reply to comment #5)
> But it seems the config.mk change isn't part of the changesets listed as
> checkin.. I'll have to look further

Ok that hunk was never pushed... ignore for now.
You need to log in before you can comment on or make changes to this bug.