478607 - Download manager should support three finger swipe up/down on Mac OS X

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090214 Shiretoko/3.1b3pre Ubiquity/0.1.5 ID:20090214020701

To be able to scroll to the top/bottom of the download manager we should support the newly added multi-touch gestures.

Comment 1

[Shawn Wilsher :sdwilsh]

I think it'd probably be dumb to do it in ever implementation - why not have the richlistbox do it?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I thought that too and already talked with Edward about it. Shall I better file a new bug for the richlistbox part and mark this bug and the error console one as dependend?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Bug 478606 has been transformed to cover the move to toolkit. Shall we add this bug to the dependency list? I think so. Even when it has been implemented any instance has to handle those events.

Comment 4

[Ed Lee :Mardak]

Attachment: v1

Generalize to richlist.. Should I just add the anon scrollbox as a member? Would be useful for writing a testcase to grab the scrollbox and see if the scrollTop actually changed.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'm not the right reviewer for toolkit.

Comment 6

[Ed Lee :Mardak]

Comment on attachment 362495 [details] [diff] [review]
v1

Oh oops. :p I searched for toolkit then searched for widget.

Well.. I'll r? shawn for now but I'll probably need to find someone else too..

Comment 7

[Shawn Wilsher :sdwilsh]

Comment on attachment 362495 [details] [diff] [review]
v1

You want Neil for this.

Comment 8

[Neil Deakin]

So the MozSwipeGesture event means move the first (or last) item? I would have expected it to mean move by page. Or does the event not give any indicator of how far or how fast?

Comment 9

[Tom Dyas]

Mac OS X currently only reports the direction of the three-fingered swipe.  The only multi-touch gestures with an associated magnitude are the zoom and rotate gestures.  The "delta" attribute of SimpleGestureEvent is not used for swipe events.

Comment 10

[Ed Lee :Mardak]

Neil: Swipe up/down doesn't necessarily mean anything right now. In the main browser of Firefox, it goes to the top/bottom of the page. But it could just as well mean "open new tab" or "close tab".

3-finger swipe up/down has been pretty useful in going to the top/bottom of the page though. So that's why the generalization to richlistboxes and trees. But then that means implementing swipe up/down as top/bottom for most other things as well down the line... maybe?

Comment 11

[Neil Deakin]

Comment on attachment 362495 [details] [diff] [review]
v1

OK, but why not put this in listbox.xml so listboxes can have the same behaviour?

Comment 12

[Ed Lee :Mardak]

http://hg.mozilla.org/mozilla-central/rev/6664e8582fee

We should be able to send a swipe mouse event on a download manager chrome test.. checking if it actually scrolled... probably getAnonymousElementByAttribute main-box and check scrollTop?

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Edward, do you plan to file a new bug or open this one for the removal of the needless handler in the richlistbox binding? We already have it in the listbox binding. See bug 478939.

Comment 14

[Ed Lee :Mardak]

The listbox swipe handling is in the listbox binding but richlistbox extends listbox-base. The listbox implementation uses ensureIndexIsVisible which is implemented as part of listbox but not listbox-base.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Means no further change will be made here and this bug can be verified?

Comment 16

[Ed Lee :Mardak]

Sure. I suppose we can wait a few days to bake.. I think that's part of the approval process guidelines..

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090221 Minefield/3.2a1pre Ubiquity/0.1.5 ID:20090221020633

Comment 18

[(not currently active) Ted Mielczarek]

Comment on attachment 362495 [details] [diff] [review]
v1

Please re-nominate when you have tests.