478878 - [hu] Search engine setup for Firefox 3.1 for Hungarian.

Status: VERIFIED FIXED

(Mozilla Localizations :: hu / Hungarian, defect)

Description

[Staś Małolepszy :stas]

Before the 3.0 release, a good set of search engines was chosen for Hungarian, but only Wikipedia (hu) landed in the end. See bug 412184 for details.

Google
Polymeta (permission: bug 412184 comment 2)
Sztaki (permission: bug 412184 comment 16)
CC
eBay
Vatera (permission: bug 412184 comment 20)
Wikipedia (hu)

Andras, if this set of search engines is still something you would like to see in 3.1, we should try to implement this.

Let me know what your thoughts are and if you'd need technical assistance in preparing the plug-ins. I'll be happy to help.





Please don't commit any modifications in l10n/hu/browser/searchplugins to the cvs repository without a patch reviewed by Stas, Axel or someone else appointed by Stas or SethB. The data here is sensitive to users and our search partners, thus the extra care here.

Comment 1

[Andras Timar]

Staś, in regards of preparing the plugins I definitely need your help, because I don't know how to make/deal with search plugins.

Polymeta and Vatera have their plugins on mycroft.mozdev.org:
http://mycroft.mozdev.org/search-engines.html?name=polymeta.hu
http://mycroft.mozdev.org/search-engines.html?name=vatera.hu
These plugins seem to work well.

For Sztaki, we have many plugins, probably we should support only the English-Hungarian dictionary. See "angol-magyar" at http://dict.sztaki.hu/docs/searchplugins.html

Google, CC and eBay are alyready in standard installation, aren't they?

Comment 2

[Staś Małolepszy :stas]

Thanks Andras for your quick reply! :)

(In reply to comment #1)
> Staś, in regards of preparing the plugins I definitely need your help, because
> I don't know how to make/deal with search plugins.

Sure, I'll be happy to help.

> Polymeta and Vatera have their plugins on mycroft.mozdev.org:
> http://mycroft.mozdev.org/search-engines.html?name=polymeta.hu
> http://mycroft.mozdev.org/search-engines.html?name=vatera.hu
> These plugins seem to work well.

Great, I'll review them tomorrow and make any necessary changes.

> For Sztaki, we have many plugins, probably we should support only the
> English-Hungarian dictionary. See "angol-magyar" at
> http://dict.sztaki.hu/docs/searchplugins.html

en-hu sounds good to me. I'll create the plug-in tomorrow.

> Google, CC and eBay are alyready in standard installation, aren't they?

Yep, we don't need to worry about them, we'll use the defaults. One thing about eBay though -- should we prefer ebay.co.uk over ebay.com?

Comment 3

[Andras Timar]

ebay.com is better, I think. I've never used ebay.co.uk. Isn't that a sort of "UK only" site?

Comment 4

[Staś Małolepszy :stas]

It is, but in the same way in which ebay.com is a "US only" site. My guess is that the shipping prices from UK to Hungary are lower than from the US, hence my suggestion. From what I was able to see, a 2kg package from UK to Hungary is approximately 10-15 GBP (15-22 USD), while the same thing is 30-40 USD (for shipping) when sent from the US.

Comment 5

[Andras Timar]

I do not use eBay frequently (so far I've ordered 2 items from eBay, both from China. :) ). Probably you are right. Another plus for the UK site that no customs should be payed for goods within EU.

Comment 6

[Staś Małolepszy :stas]

Attachment: Search plug-ins

Here's the patch with PolyMeta, Vatera, Sztaki and eBay.co.uk search plug-ins. PolyMeta takes Yahoo's second place, as per bug 412184.

Gandalf, can you do a quick sanity review for me, please?
Andras, mind checking if all the descriptions and titles are correct and in Hungarian? 

Thanks.

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 363680 [details] [diff] [review]
Search plug-ins

looks good, applies against branch. r+

Comment 8

[Andras Timar]

Attachment: with correct descriptions

I fixed the descriptions, one was in English, one was in Hungarian but grammatically incorrect, and one was in Polish or Czech (?).

Comment 9

[Staś Małolepszy :stas]

Comment on attachment 363685 [details] [diff] [review]
with correct descriptions

Looks like Czech or Slovak, not sure. I took it directly from mycroft's plug-in, and it did seem a bit not-Hungarian-enough to me ;) Glad that you fixed it and other descriptions too. Let's land this baby.

Please land this patch on 3.1 and 3.2 branches using a verbose check-in comment, e.g. "Bug 478878: Search engine setup for Firefox 3.1 for Hungarian, added PolyMeta, Sztaki, Vatera, eBay.co.uk, removed Amazon, Answers, eBay.com and Yahoo. r=stas/gandalf" Please use fixed1.9.1 and verified1.9.1 keywords in this bug to track landing and verification in the testing builds. 

Thanks!

Comment 10

[Andras Timar]

Committed to both 3.1 and 3.2 branches.

Comment 11

[Staś Małolepszy :stas]

Thanks!

For reference, here are the commits:
http://hg.mozilla.org/l10n-central/hu/rev/b1baab72b8c9
http://hg.mozilla.org/l10n-central/hu/rev/d776c82a26fb
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/hu/rev/8758701cd41a
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/hu/rev/1450a0c52643

I also updated the wiki page here: https://wiki.mozilla.org/L10n:Firefox_web_services_status:hu#Search_Engines

Comment 12

[Andras Timar]

Verified in latest-mozilla-1.9.1-l10n hu win32 build 02/24/2009