478948 - SQL statements not finalized warnings during shutdown

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Boris Zbarsky [:bzbarsky]]

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIIdleService.removeIdleObserver]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///Users/bzbarsky/mozilla/css-frameconst/obj-firefox/dist/MinefieldDebug.app/Contents/MacOS/components/nsBrowserGlue.js :: anonymous :: line 202"  data: no]
************************************************************
WARNING: SQL statement 'DELETE FROM moz_historyvisits_temp WHERE visit_type <> 4' was not finalized: file /Users/bzbarsky/mozilla/css-frameconst/mozilla/storage/src/mozStorageConnection.cpp, line 254
WARNING: SQL statement 'DELETE FROM moz_places_temp WHERE id IN (SELECT id FROM moz_places_temp h WHERE h.hidden <> 1 OR NOT EXISTS ( SELECT id FROM moz_historyvisits_temp WHERE place_id = h.id AND visit_type = 4 LIMIT 1) )' was not finalized: file /Users/bzbarsky/mozilla/css-frameconst/mozilla/storage/src/mozStorageConnection.cpp, line 254
WARNING: sqlite3_close failed. There are probably outstanding statements that are listed above!: file /Users/bzbarsky/mozilla/css-frameconst/mozilla/storage/src/mozStorageConnection.cpp, line 267
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80630001 [mozIStorageConnection.close]"  nsresult: "0x80630001 (<unknown>)"  location: "JS frame :: file:///Users/bzbarsky/mozilla/css-frameconst/obj-firefox/dist/MinefieldDebug.app/Contents/MacOS/components/nsPlacesDBFlush.js :: anonymous :: line 135"  data: no]
************************************************************

Not sure whether that first JS error is relevant to this.

Comment 1

[Shawn Wilsher :sdwilsh]

I don't think the first error is relevant, but this issue is odd.  Those statements are cached, and they should be finalized just before we try to close the db:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsPlacesDBFlush.js#134

Unless my js magic is totally wrong there...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Your JS magic is wrong.  forEach on an array enumerates the properties that:

1) Are set
2) Have names that are nonnegative integers < array.length.

In other words, actual array elements.

In your case, you're setting properties on this array keyed by table name, so there are none such.  When I'm shutting down this array thinks it has length 0.

You probably want an array to handle finalization (with push() used to put things in it) and a separate (non-array) object mapping names to statements for lookup.

Looks like a regression from bug 468705.

Comment 3

[Shawn Wilsher :sdwilsh]

Bah, yeah.  I really want an object I guess for cacheing, and use the array with push to store for finalization.

Comment 4

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Don't need to use the array if I just make sure that what I'm iterating is a storage statement.

Comment 5

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/8966535ccf1b

Comment 6

[Shawn Wilsher :sdwilsh]

Fixed in http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c320a12b4b86 which was pushed for bug 468705.