479391 - 250k increase in tracemalloc leaks from bug 468705

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Karl Tomlinson (:karlt)]

http://graphs.mozilla.org/#show=1473418,1473670,1474269&sel=1234540503,1234592474

Tinderbox shows an increase from revision b0337b6287f3 to 57e905485264.
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox&maxdate=1234607987&legend=0&norules=1
There are no intermediate revisions so this implicates bug 468705.
Perhaps it is caused by bug 478948, but this separate bug can track whether it is the same issue.

Comment 1

[Marco Bonardo [:mak]]

well if statements are not finalized the connection is not closed, so most likely we could leak history service

Comment 2

[Shawn Wilsher :sdwilsh]

(In reply to comment #1)
> well if statements are not finalized the connection is not closed, so most
> likely we could leak history service
That's not true - at worst we might leak some of the sqlite connection.  If it was caused by bug 468705, this should be fixed by bug 478948.

Otherwise, I don't see how JS could be causing tracemalloc leaks.

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: diffbloatdump

From http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1234566926.1234568727.1948.gz

All the new leaks are using sqlite3Malloc.

Comment 4

[Shawn Wilsher :sdwilsh]

Looks to me like this has been fixed.  Karl, can you confirm please?

Comment 5

[Karl Tomlinson (:karlt)]

Yes, looks good to me, thanks.

-249664 malloc
  -249976 sqlite3MemMalloc[sqlite3 +0x415D]
    -249976 sqlite3Malloc[sqlite3 +0x47F4]

Comment 6

[Shawn Wilsher :sdwilsh]

Filed bug 479543 to make the warnings go to errors.