Closed Bug 479391 Opened 12 years ago Closed 12 years ago

250k increase in tracemalloc leaks from bug 468705

Categories

(Toolkit :: Places, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: karlt, Unassigned)

References

Details

(Keywords: regression, Whiteboard: [fixed by bug 478948])

Attachments

(1 file)

http://graphs.mozilla.org/#show=1473418,1473670,1474269&sel=1234540503,1234592474

Tinderbox shows an increase from revision b0337b6287f3 to 57e905485264.
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox&maxdate=1234607987&legend=0&norules=1
There are no intermediate revisions so this implicates bug 468705.
Perhaps it is caused by bug 478948, but this separate bug can track whether it is the same issue.
well if statements are not finalized the connection is not closed, so most likely we could leak history service
(In reply to comment #1)
> well if statements are not finalized the connection is not closed, so most
> likely we could leak history service
That's not true - at worst we might leak some of the sqlite connection.  If it was caused by bug 468705, this should be fixed by bug 478948.

Otherwise, I don't see how JS could be causing tracemalloc leaks.
Looks to me like this has been fixed.  Karl, can you confirm please?
Yes, looks good to me, thanks.

-249664 malloc
  -249976 sqlite3MemMalloc[sqlite3 +0x415D]
    -249976 sqlite3Malloc[sqlite3 +0x47F4]
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 478948]
Filed bug 479543 to make the warnings go to errors.
You need to log in before you can comment on or make changes to this bug.