479107 - non-ASCII characters aren't decoded correctly after customize toolbar

Status: RESOLVED FIXED

(SeaMonkey :: Location Bar, defect)

Description

[Pavel Cvrcek [:JasnaPaka]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; cs; rv:1.9.1b3pre) Gecko/20090218

Steps to reproduce:
1) In browser set toolbar icons to small size.
2) Visit URL: http://cs.wikipedia.org/wiki/Vla%C5%A1sk%C3%BD_o%C5%99ech
3) Restore toolbar to default.

Now you can see URL which isn't decoded correctly.

Comment 1

[lenochod]

I can confirm it with  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090219 SeaMonkey/2.0b1pre.

Change shall be made by the item "Customize... => Use Small Icons"

Comment 2

[Misak Khachatryan]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090221 NOT Firefox/2.0.0.20 SeaMonkey/2.0a3pre ID:20090221175141

I can't reproduce this on Fedora Core 10.

Comment 3

[[e-mail]]

I see the problem - we forgot to update BrowserCustomizeToolboxDone()...

Comment 4

[Philip Chee]

I even have a XXXRatty placeholder comment there.

Comment 5

[Robert Kaiser]

I wouldn't push out any specific release for this, as nothing is really broken, but we'll need a fix at some time in this cycle.

Comment 6

[Philip Chee]

I can't see any difference. Can someone comment on the actual string seen vs the expected string.

Comment 7

[Pavel Cvrcek [:JasnaPaka]]

Attachment: URLBar (before toolbar customization)

Comment 8

[Pavel Cvrcek [:JasnaPaka]]

Attachment: URLBar (after toolbar customization)

Comment 9

[Pavel Cvrcek [:JasnaPaka]]

(In reply to comment #6)
> I can't see any difference. Can someone comment on the actual string seen vs
> the expected string.

See attachments.

Comment 10

[Philip Chee]

Attachment: Patch v1.0 Update URLBar.

> See attachments.

Thanks I see it now.

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 448040 [details] [diff] [review]
Patch v1.0 Update URLBar.

>   // Update the urlbar
>-  var value = gBrowser.userTypedValue;
...
>-  gURLBar.value = value;
>+  URLBarSetURI();

I'm not sure what's going on with SM's URLBarSetURI implementation. Unlike Firefox's, it doesn't seem to read userTypedValue (but resets it even).

Comment 12

[[e-mail]]

(In reply to comment #11)
> (From update of attachment 448040 [details] [diff] [review])
> >   // Update the urlbar
> >-  var value = gBrowser.userTypedValue;
> ...
> >-  gURLBar.value = value;
> >+  URLBarSetURI();
> I'm not sure what's going on with SM's URLBarSetURI implementation. Unlike
> Firefox's, it doesn't seem to read userTypedValue (but resets it even).
Our version expects the caller to deal with reading userTypedValue (and assumes that it was or it needs to be reset).

Comment 13

[[e-mail]]

Comment on attachment 448040 [details] [diff] [review]
Patch v1.0 Update URLBar.

As per comment 11.

Comment 14

[Philip Chee]

Attachment: Patch v1.1 Restore userTypedValue.

>> I'm not sure what's going on with SM's URLBarSetURI implementation. Unlike
>> Firefox's, it doesn't seem to read userTypedValue (but resets it even).
> Our version expects the caller to deal with reading userTypedValue (and assumes
> that it was or it needs to be reset).

I hope I've understood Comment 11 correctly.

Comment 15

[Dão Gottwald [:dao]]

You can test the outcome quite easily: Type into the location bar, customize toolbars, cancel, observe whether the typed value is restored.

Comment 16

[[e-mail]]

Comment on attachment 448196 [details] [diff] [review]
Patch v1.1 Restore userTypedValue.

Don't you actually need to restore the user typed value (if any) to the URLbar itself?

Comment 17

[Philip Chee]

Attachment: Patch v1.2 Restore to gURLBar.value as well.

> Don't you actually need to restore the user typed value (if any) to the URLbar
> itself?
Ah, finally understood what userTypedValue is used for.

Comment 18

[[e-mail]]

Comment on attachment 448273 [details] [diff] [review]
Patch v1.2 Restore to gURLBar.value as well.

Well, that's functional, but when you do have a user typed value then you're making work for yourself by setting the URLbar twice and having to restore userTypedValue too.

Comment 19

[Philip Chee]

Attachment: Patch v1.3 Don't do unnecessary work.

> Well, that's functional, but when you do have a user typed value then you're
> making work for yourself by setting the URLbar twice and having to restore
> userTypedValue too.
Sorry about that. Fixed.

Comment 20

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/27777aeb1642