569318 - Favicon is visible during toolbar customisation

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Visit a site with a favicon
2. (Optional) Modify the URL in the URLbar, thus hiding the favicon
3. Start toolbar customisation

Actual result: Favicon reappears during and after customisation, even if it was temporarily hidden by URLbar modification.

Expected result: Since a blank URLbar is displayed, I suggest that we use the icon normally displayed when the URLbar is blank, which is the "invalid" icon.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[[e-mail]]

Note that bug 479107 will allow the favicon to reappear in some cases (those in which it would reappear when you press ESC to cancel URL modification).

Comment 3

[Ian Neal]

Comment on attachment 448477 [details] [diff] [review]
Proposed patch

It would be nice if the favicon reappeared after customization. Is that possible?

Comment 4

[[e-mail]]

Sorry, you needed to read comment 2 but I failed both to include that as part of the review request and then again to CC you when I did comment...

Comment 5

[Ian Neal]

Comment on attachment 448477 [details] [diff] [review]
Proposed patch

r=me
is there a bug open for the other cases to get the favicon back after customization?

Comment 6

[[e-mail]]

Pushed changeset 9c87825cdd57 to comm-central.