479197 - The mini_login Bugzilla_password box does not convert to text type or clear itself in IE

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Max Kanat-Alexander]

In IE7, apparently we can't change the type of an input from password to text? I just see a password box. This would possibly be OK (because I think people would figure it out), but the box also doesn't clear itself when you focus it.

Comment 1

[Max Kanat-Alexander]

Oh, and I'm referring to the mini_login form, of course, in the header and footer.

Comment 2

[Frédéric Buclin]

Why not leaving the field as a password field only?

Comment 3

[Max Kanat-Alexander]

This isn't a regression--the mini_login form didn't exist before.

The problem is that it *is* being left as a password field in IE. Try using HEAD in Firefox (without any saved login data) and then in IE and you'll see what I'm talking about.

Comment 4

[Max Kanat-Alexander]

Attachment: v1

Okay, this fixes the problem. We make the "password" box be a hidden field by default, and put a "dummy" box there instead with the word "password" in it. This is all done via JS so that everything works normally for users w/o JS.

Comment 5

[Max Kanat-Alexander]

Attachment: v2

I decided to be nice to Opera too.

Comment 6

[:glob ✱]

Comment on attachment 363825 [details] [diff] [review]
v2

r=glob

also, urgh.

Comment 7

[Max Kanat-Alexander]

Yeah, urgh is right. :-)

Comment 8

[Max Kanat-Alexander]

Checking in js/global.js;
/cvsroot/mozilla/webtools/bugzilla/js/global.js,v  <--  global.js
new revision: 1.2; previous revision: 1.1
done
Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.62; previous revision: 1.61
done
Checking in template/en/default/account/auth/login-small.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login-small.html.tmpl,v  <--  login-small.html.tmpl
new revision: 1.14; previous revision: 1.13
done