47932 - Deleted cards in Collected AB doesn't get re-created.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P2)

Description

[Suresh]

Steps:
1. Read a msg. (say sender is [e-mail]). The sender is added to 
Collected AB by default. 
2. Launch AB and delete this card ([e-mail]) from Collected AB.
3. Read another mail from the same person (or send a mail to the same address). 
There is no entry for the address in Collected AB. 

Note:
1. Doesn't matter pop/imap account, migrated/new profile.
2. I think this is the problem behind bug 47135 (which is logged by fenella).

Build and Platform:
Today's branch (M17) builds on all platforms.

Comment 1

[Suresh]

I think this is no longer related to just Collected AB. This occurs in Personal 
AB (PAB) also. Steps to reproduce in PAB.

1. Assume the AB's doesn't have any entries in it. 
2. Create a new mailing list (list1) in PAB and add two entries to it 
([e-mail] and [e-mail]). These two emails are 
automatically added to PAB.  
3. Delete one email ([e-mail]) from PAB. => it is also deleted from 
the list1.  (So far so good :))
4. Now create another mailing list (list2) in PAB. Add two entries to it, say 
[e-mail] and [e-mail].  email3 is added to PAB. email1 is 
_not_ added to PAB. It should.

Comment 2

[scottputterman]

reassigning to chuang.

Comment 3

[lchiang]

+ per mail triage, P2

Comment 4

[chuang]

Reassign to bienvenu.  I traced the code, it looks like mork FindRow() still 
find the deleted row (address book use CutRow())in database.  I have tried on 
both in the same session or restart the application.  

The calling function for FindRow() call is in 
nsAddrDatabase::GetRowForCharColumn();

Comment 5

[David :Bienvenu]

that just means you have a ref-counting problem, I bet (i.e., holding onto an 
extra ref). It works fine for e-mail.

Comment 6

[David :Bienvenu]

have you tried cutting all columns as well, like the msg db code does?
e.g., 		row->CutAllColumns(GetEnv());

Plus, I'm not sure you've got all your ref-counting right, in the code I looked 
at anyway.

Comment 7

[chuang]

ok, I'll take it back and look for the ref count problem.

Comment 8

[David :Bienvenu]

The following code, for example, leaks:

				for(PRUint32 i = 0; i < cardCount; i++)
				{
					nsISupports* cardSupports = cardArray->ElementAt(i);
					nsIAbCard* card = (nsIAbCard*)cardSupports;
					if (card)
					{
						database->DeleteCard(card, PR_TRUE);
					}
				}


because cardArray->ElementAt(i) addrefs, but you're never releasing. nsCOMPtrs
would help with problems like these.

Comment 9

[chuang]

Calling CutAllColumns() fixed the problem.  I'll make sure it also fix for 
Personal address book, Mailing list.  Ref count may not be the problem here.

Comment 10

[David :Bienvenu]

Great! But even if the ref-counting isn't the problem here, it will cause memory
leaks so we should clean that up too.

Comment 11

[chuang]

Fix checked in Yesterday.

Comment 12

[chuang]

marked fixed

Comment 13

[esther]

Using build 2000-09-06 on win98, mac and linux this is fixed.  Verified.