Closed
Bug 479343
Opened 16 years ago
Closed 16 years ago
Implement Upcoming Events block
Categories
(Websites Graveyard :: spreadfirefox.com, defect)
Websites Graveyard
spreadfirefox.com
Tracking
(Not tracked)
VERIFIED
FIXED
3.0
People
(Reporter: abuchanan, Assigned: neilio)
References
()
Details
(Whiteboard: style)
Attachments
(7 files)
|
2.65 KB,
patch
|
abuchanan
:
review+
|
Details | Diff | Splinter Review |
|
11.66 KB,
application/octet-stream
|
abuchanan
:
review+
|
Details |
|
144.68 KB,
image/tiff
|
Details | |
|
140.05 KB,
image/png
|
Details | |
|
753.89 KB,
image/png
|
Details | |
|
1.77 KB,
patch
|
abuchanan
:
review+
|
Details | Diff | Splinter Review |
|
8.79 KB,
application/octet-stream
|
abuchanan
:
review+
|
Details |
On the news/events page, the block on the lower left, the Upcoming Events still needs to be implemented.
Comment 1•16 years ago
|
||
My mock, MOZ-014_SpreadFirefox_CR3rev_Page_5.jpg, has this on the mid-right section, just below the "Quick Wins" block; is that not correct?
| Reporter | ||
Comment 3•16 years ago
|
||
correct, I have it in the right sidebar, under quick wins -> download counter -> upcoming events
MOZ-014_SpreadFirefox_CR3rev_Page_5.jpg
tomato.. wait that doesn't work when you type it...
Updated•16 years ago
|
Severity: normal → blocker
| Assignee | ||
Comment 4•16 years ago
|
||
Here's the changes to implement the upcoming events block. There are two new images needed which I will also attach to this bug.
Attachment #364234 -
Flags: review?(buchanae)
| Assignee | ||
Comment 5•16 years ago
|
||
New bg images for upcoming events box (goes in img directory).
Attachment #364235 -
Flags: review?(buchanae)
| Reporter | ||
Updated•16 years ago
|
Attachment #364234 -
Flags: review?(buchanae) → review+
| Reporter | ||
Updated•16 years ago
|
Attachment #364235 -
Flags: review?(buchanae) → review+
| Reporter | ||
Comment 6•16 years ago
|
||
i've checked in the attached patch + images to SVN in r22745
a couple things to note...
1) the listed events aren't actual yet, Paul B. or I will have to set that up
2) the background footer image ends in the middle of the block. Neil is this something we can't repeat-y indefinitely?
Thanks
Updated•16 years ago
|
Loving the progress here, thanks Neil & Alex!
Is the background footer image related to the overall look and feel of the block?
It should look like a sheet of paper with shadowing behind it. Also the gray line in between the listing and the "Upcoming Events" fads out in the design.
Attaching image of it...
| Assignee | ||
Comment 9•16 years ago
|
||
Not sure what the issue is - I cut the image directly out of the mockup, so what you see is what you get, for the most part. The lines on the left and right sides of the box are very, very light, so they could just be getting lost in the difference between our displays.
Comment 10•16 years ago
|
||
Hey there: Wanted to close the loop -- it looks fine now and it's with the same display. So not sure what you all did :)
Alex: Have you been able to work on getting the events to populate it?
Comment 11•16 years ago
|
||
screenshot using xp screen resolution 1024x768
marked with arrows missing css background images and tabs on the menu
| Reporter | ||
Comment 12•16 years ago
|
||
r22899 populates with actual events
NOTE: there is still a CSS issue with the bg image
Not sure if we want to keep bug 479343 separate from this.
(In reply to comment #13)
> Not sure if we want to keep bug 479343 separate from this.
Cut-'n-paste fail; so spammy today: really meant bug 481698.
| Reporter | ||
Comment 15•16 years ago
|
||
Neil, is there something you can do to fix the background image/css issue? It'd be awesome if these blocks can be vertically expandable indefinitely.
If not, the alternative for this block would be to cut down the number of events entries listed.
Also, can you add some min-height to these blocks, so that when they have short/brief content they don't look offset?
Thanks!
Updated•16 years ago
|
Whiteboard: style
| Assignee | ||
Comment 16•16 years ago
|
||
It's div-errific, but it works. This patch fixes the background image issue behind the events box.
Attachment #368820 -
Flags: review?(buchanae)
| Assignee | ||
Comment 17•16 years ago
|
||
Attachment #368821 -
Flags: review?(buchanae)
| Reporter | ||
Comment 18•16 years ago
|
||
Comment on attachment 368820 [details] [diff] [review]
Patch to fix background image issues
yay
Attachment #368820 -
Flags: review?(buchanae) → review+
| Reporter | ||
Updated•16 years ago
|
Attachment #368821 -
Flags: review?(buchanae) → review+
| Reporter | ||
Comment 19•16 years ago
|
||
Thank you
r23696
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Verified FIXED using:
* Safari 3.2.2
* Firefox 2.0.0.20
* Firefox 3.0.7
* Firefox 3.1 beta 3
* Opera 9.64
IE 6 and 7 have issues: see bug 484925 for that.
Status: RESOLVED → VERIFIED
Updated•14 years ago
|
Product: Websites → Websites Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•