Closed Bug 479505 Opened 15 years ago Closed 15 years ago

Fix header theme to work well in XP as well as Vista

Categories

(Thunderbird :: Message Reader UI, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: davida, Assigned: davida)

Details

(Whiteboard: [has css patch needs review bienvenu & ui-review clarkbw][could use better patch])

Attachments

(5 files, 1 obsolete file)

Attached patch css patch (obsolete) — Splinter Review
the current header theme was tested w/ Vista, but not XP.  We can and should do better.

bryan and i worked on this one, and it looks better in both.
Flags: blocking-thunderbird3+
Attachment #363368 - Flags: ui-review?(clarkbw)
Attachment #363368 - Flags: review?(philringnalda)
Attached image xp screenshot
xp screenshot
Assignee: nobody → david.ascher
Status: NEW → ASSIGNED
Attached image vista screenshot
Comment on attachment 363368 [details] [diff] [review]
css patch

much better.
Attachment #363368 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 363368 [details] [diff] [review]
css patch

I heard philor saying on IRC that he's taking the weekend, so switching review to bienvenu in hope of landing this well before monday build cutoff.
Attachment #363368 - Flags: review?(philringnalda) → review?(bienvenu)
Attachment #363368 - Flags: review?(bienvenu) → review+
looks much better, thx. I've landed this on the trunk. Gozer will need to put this on the b2 release branch - here's the trunk rev - http://hg.mozilla.org/comm-central/rev/649c44ace6dc
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attached image empty button
Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9.1b3pre) Gecko/20090222 Shredder/3.0b3pre

Hovering Show details button hides its icon (no down arrow) and makes whole header 1 pixel taller. De-hovering returns header size to normal size, so when you're moving mouse pointer over the button, header is 'jumping'.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Thanks for catching this!

The attached patch fixes the empty button on hover and jiggle, at least on XP (don't have Vista handy)
Attachment #363368 - Attachment is obsolete: true
Attachment #363644 - Flags: ui-review?(clarkbw)
Attachment #363644 - Flags: review?
Attached image showing 'fix'
This is what XP looks like.  The padding on the right isn't quite right, but i can't figure out why.  At least this is better than what's in the tree, and hopefully we can figure out a better fix tomorrow.
Whiteboard: [has css patch needs review bienvenu & ui-review clarkbw][could use better patch]
Comment on attachment 363644 [details] [diff] [review]
fix for empty button

Yep, this works fine on Vista too.
Attachment #363644 - Flags: review? → review+
latest fix pushed - 
http://hg.mozilla.org/comm-central/rev/286eb49b8139
Status: REOPENED → RESOLVED
Closed: 15 years ago15 years ago
Resolution: --- → FIXED
Applied the 2 patches to the release branch:

changeset:   2050:e500c93556ad
branch:      COMM_20090224_RELBRANCH
user:        David Ascher <david.ascher@gmail.com>
date:        Sat Feb 21 20:02:46 2009 -0800
summary:     fix header theme to work well in xp as well as vista, r=bienvenu, 479505

changeset:   2052:ef476a9b1734
branch:      COMM_20090224_RELBRANCH
tag:         tip
parent:      2050:e500c93556ad
user:        David Ascher <david.ascher@gmail.com>
date:        Mon Feb 23 09:37:22 2009 -0800
summary:     fix more details hover button in qute on XP, r=bienvenu, 479505
Comment on attachment 363644 [details] [diff] [review]
fix for empty button

yep, sorry for the delay
Attachment #363644 - Flags: ui-review?(clarkbw) → ui-review+
You need to log in before you can comment on or make changes to this bug.