479532 - OrganizerCommand_find:current keybinding clobbers OrganizerCommand_find:all in Library on Mac OS X

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Drew Willcoxon :adw]

It's impossible to use OrganizerCommand_find:all from the keyboard on OS X (which makes it impossible to use it at all).

The code below hooks up the edit menu's Find menuitem to OrganizerCommand_find:current.  The key on that menuitem is key_find, which is accel+F.  But placesKey_find:all, the key on OrganizerCommand_find:all, is also accel+F.  find:current wins.

http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/places.js#88
88 #ifdef XP_MACOSX
89     // 1. Map Edit->Find command to the organizer's command
90     var findMenuItem = document.getElementById("menu_find");
91     findMenuItem.setAttribute("command", "OrganizerCommand_find:current");
92     var findKey = document.getElementById("key_find");
93     findKey.setAttribute("command", "OrganizerCommand_find:current");

Relevant files:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-menubar.inc#181 (menu_find, the Edit menu's Find item)
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sets.inc#274 (key_find, menu_find's key)
http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.dtd#401 (key_find's actual en-US key (F))
http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/places.js#88 (overrides menu_find's command to find:current)
http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/places.xul#102 (find:all and find:current commands)
http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/places.xul#135 (placesKey_find:all and placesKey_find:current)

From bug 434704.

Comment 1

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv