479632 - Recent folders view displays the same as the previous one (ie: either all or favorite folders)

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[orel.linux]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9.0.6) Gecko/2009020911 Ubuntu/8.10 (intrepid) Firefox/3.0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.1b3pre) Gecko/20081204 Lightning/1.0pre Thunderbird/3.0b1 Mnenhy/0.7.6.0 ID:20090218143233

When changing the folder view, "recent folders" displays the same as the previous view. 

For example, if you clicked on the right arrow, you will see the list of favorite folders and then recent folders. In this case, the recent folders view shows the favorite folders.

If you clicked on the left arrow, you the recent folders view shows all folders.

Reproducible: Always

Steps to Reproduce:
1.click on one of the arrows for folders views
Actual Results:  
There is no change between the previous view (favorite folders if you used the right arrow, all folders with the left arrow) and the recent folders view. The text "Recent folders" is displayed correctly but not the folders.

Expected Results:  
It should display the recent folders.

This bug was already in the beta1 (tested yesterday) and still in the 20090218 build.

Comment 1

[Mark Banner (:standard8)]

Taking, I think I see the fault. Not sure if we want this in the B2 respin.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

Putting a let definition inside a try/catch when you want the value outside of the try/catch isn't a good idea.

Comment 3

[Wayne Mery (:wsmwk)]

regression ?

Comment 4

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/8172ffc1edd3

Do we want this in the b2 respin?

Comment 5

[Ludovic Hirlimann [:Usul]]

(In reply to comment #1)
> Taking, I think I see the fault. Not sure if we want this in the B2 respin.

I would say yes there. The change is small enough to avoid side effects. So I would like to have this in the respin.

Comment 6

[Mark Banner (:standard8)]

FWIW this was a regression from bug 468656.

Comment 7

[Philippe M. Chiasson (:gozer)]

Applied to release-branch:

changeset:   2044:7db1d7c5d187
branch:      COMM_20090224_RELBRANCH
tag:         tip
user:        Mark Banner <[e-mail]>
date:        Sun Feb 22 19:26:18 2009 +0000
summary:     Bug 479632 Recent folders view displays the same as the previous one. r=bienvenu