479675 - Vertical border lines don't connect on the "Impact Mozilla Challenge" box

Status: VERIFIED FIXED

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

On https://spreadfirefox.authstage.mozilla.com/news_events, the vertical border lines don't connect on the "Impact Mozilla Challenge" box.

Comment 1

[Alex Buchanan [:abuchanan]]

Neil, I think this was intended to be fixed by your patch on bug 479671, but I still see this bug.

So just noting this is still a bug :)

Comment 2

[Mary]

Also, this is impacting the events block.  Is this fixed in today's round?

Comment 3

[Mary]

Attachment: Events block

You can see the lines don't connect on the sides of the block.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> Created an attachment (id=366403) [details]
> Events block 
> 
> You can see the lines don't connect on the sides of the block.

Your above attachment displays garbled for me; see also

https://bugzilla.mozilla.org/show_bug.cgi?id=479343#c11

Comment 5

[Neil Lee [:neilio]]

Attachment: Fixed background image

I found the issue - the wrong image was part of the previous patch. Here's the correct image which should fix the problem.

Comment 6

[Mary]

Thanks :)

Comment 7

[Alex Buchanan [:abuchanan]]

Comment on attachment 366464 [details]
Fixed background image

Which image is this replacing?  staplepadfooter.png?

If so, I tried replacing the image through firebug and it doesn't turn out very clean.  See screenshot.

Comment 8

[Alex Buchanan [:abuchanan]]

Attachment: replacing staplepadfooter.png with attachment 366464

replacing staplepadfooter.png with attachment 366464 [details]

Comment 9

[Mary]

Still looking crummy :(  Neil:  Any chance to look at this again?

Comment 10

[Neil Lee [:neilio]]

Attachment: Fixes background image issue, closer, but not perfect yet

This closes the gap and gets the boxes closer, but to really fix this properly there needs to be an editorial change or HTML - either the heading (Impact Mozilla, for example) needs to be constrained to a set length (one line only, for example) OR I can implement the background in a similar way as the events box fix, but it's a) ugly HTML, and b) may not be great for screenreaders. Let me know what y'all think is better.

Comment 11

[Neil Lee [:neilio]]

Attachment: New images to go with the above patch.

Comment 12

[Alex Buchanan [:abuchanan]]

Comment on attachment 368825 [details] [diff] [review]
Fixes background image issue, closer, but not perfect yet

woot

Comment 13

[Alex Buchanan [:abuchanan]]

Thanks!

r23695

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

I tested on literally every browser we support; let me enumerate them:

* Firefox 2.0.0.20
* Firefox 3.0.7
* IE 6
* IE 7
* Opera 9.64
* Safari 3.2.2

Verified FIXED (and there was much rejoicing!)